o Added a Clone() method to InterchangeObject and derivatives

   that allows making a descriptor copy that is not owned by
   any other strucure. The caller must arrange to delete the
   object pointer returned.

 o While implementing the above it became obvious that the
   reference-to-a-pointer-to-the-dictionary idiom that is used
   throughout the lower levels of the MXF library was the
   cause of much more grief than it was originally designed to
   prevent. This was made even more obvious when I replaced all
   of it with simple pointers, which revealed several shadow
   instances of m_Dict that were only reliable while the object
   that held them was valid.

1 files changed, 5 insertions, 5 deletions

diff --git a/src/AS_DCP_DCData.cpp b/src/AS_DCP_DCData.cpp
index b957d6c..fee3ff8 100644
--- a/src/AS_DCP_DCData.cpp
+++ b/src/AS_DCP_DCData.cpp
@@ -1,5 +1,5 @@
 /*
-Copyright (c) 2004-2018, John Hurst
+Copyright (c) 2004-2021, John Hurst
 All rights reserved.
 
 Redistribution and use in source and binary forms, with or without
@@ -85,7 +85,7 @@ class ASDCP::DCData::MXFReader::h__Reader : public ASDCP::h__ASDCPReader
  public:
   DCDataDescriptor m_DDesc;
 
-  h__Reader(const Dictionary& d) : ASDCP::h__ASDCPReader(d), m_PrivateLabelCompatibilityMode(false), m_DDesc() {}
+  h__Reader(const Dictionary *d) : ASDCP::h__ASDCPReader(d), m_PrivateLabelCompatibilityMode(false), m_DDesc() {}
   ~h__Reader() {}
   Result_t    OpenRead(const std::string&);
   Result_t    ReadFrame(ui32_t, FrameBuffer&, AESDecContext*, HMACContext*);
@@ -226,7 +226,7 @@ ASDCP::DCData::FrameBuffer::Dump(FILE* stream, ui32_t dump_len) const
 
 ASDCP::DCData::MXFReader::MXFReader()
 {
-  m_Reader = new h__Reader(DefaultSMPTEDict());
+  m_Reader = new h__Reader(&DefaultSMPTEDict());
 }
 
 
@@ -379,7 +379,7 @@ public:
   DCDataDescriptor m_DDesc;
   byte_t           m_EssenceUL[SMPTE_UL_LENGTH];
 
-  h__Writer(const Dictionary& d) : ASDCP::h__ASDCPWriter(d) {
+  h__Writer(const Dictionary *d) : ASDCP::h__ASDCPWriter(d) {
     memset(m_EssenceUL, 0, SMPTE_UL_LENGTH);
   }
 
@@ -595,7 +595,7 @@ ASDCP::DCData::MXFWriter::OpenWrite(const std::string& filename, const WriterInf
     return RESULT_FORMAT;
   }
 
-  m_Writer = new h__Writer(DefaultSMPTEDict());
+  m_Writer = new h__Writer(&DefaultSMPTEDict());
   m_Writer->m_Info = Info;
 
   Result_t result = m_Writer->OpenWrite(filename, HeaderSize, SubDescriptorList_t());