dcpomatic, branch video-range-bug DCP-o-matic DCP tools https://git.carlh.net/cgit/dcpomatic/atom?h=video-range-bug 2022-08-11T21:48:40Z Fix video range in preview and DCP when source is VIDEO rather than FULL. 2022-08-11T21:48:40Z Carl Hetherington cth@carlh.net 2022-08-11T21:42:01Z urn:sha1:2e607b7968a0af94d7e38fb9d7d5459e33beed85 It looks like the handling of "video" range (16-235) sources (when creating "full" range (0-255) outputs) has been broken for some considerable time. Full range outputs are used for both preview and DCP creation. We assumed that after we called sws_setColorspaceDetails FFmpeg would take care of the conversion from video to full, but its source suggests that it refuses to convert to full-range RGB (only full-range YUV or greyscale). Previously there was a seemingly correct comment (that FFmpeg would do nothing if source _or_ destination were RGB) but the check on when to use video_range_to_full_range() was only activated for RGB sources, not (also) RGB outputs. It's hard to believe that this has been around unnoticed for so long. https://dcpomatic.com/forum/viewtopic.php?t=1928&start=10 has a discussion which pointed out the problem. Cleanup: don't repeat check inside resume() before calling it. 2022-08-11T20:40:59Z Carl Hetherington cth@carlh.net 2022-08-06T20:58:36Z urn:sha1:da75178e689a48dc689b70e0880a45f0cf8c07a8 Allow cancellation of un-started jobs (#2777). 2022-08-11T20:40:59Z Carl Hetherington cth@carlh.net 2022-08-06T20:57:58Z urn:sha1:1fe717e9125e896c92f281922e87f8158b15c7af Cleanup: set job state to cancelled in a different place. 2022-08-11T20:40:59Z Carl Hetherington cth@carlh.net 2022-08-06T20:36:21Z urn:sha1:1d3085c403f265fb203654d461c0b77974205f2f Fix d881836379172f4072ed81ea074f46b3a363a681 which removed clearing 2022-08-11T14:39:03Z Carl Hetherington cth@carlh.net 2022-08-11T14:39:03Z urn:sha1:f2b10879dcafccdb28f88d53dc1fc22094b96c1d of the left-hand-side of images. Lower some error thresholds now that check_image() actually works in these cases. 2022-08-11T14:38:38Z Carl Hetherington cth@carlh.net 2022-08-11T14:38:38Z urn:sha1:d4d9f1b9213cf6e95e840009488d84ad4a24b21b Fix broken writing of 16-bit images (the pixels must be written MSB-first). 2022-08-11T14:38:24Z Carl Hetherington cth@carlh.net 2022-08-11T14:38:24Z urn:sha1:8e4f083438e2a6234da96f63fcceadafd5a8bd03 Cleanup: remove duplicated code. 2022-08-11T14:37:57Z Carl Hetherington cth@carlh.net 2022-08-11T14:37:57Z urn:sha1:ddeecdac0600a3fe72660fb1e14b652c59f09d33 Bump libsub for fix to SSA colour tag parsing. 2022-08-10T19:09:01Z Carl Hetherington cth@carlh.net 2022-08-10T19:09:01Z urn:sha1:7abb914a871af91422a542e405d37c30bfa199f7 Fix lines down the right-hand-side of exports in some cases. 2022-08-08T22:09:30Z Carl Hetherington cth@carlh.net 2022-07-26T13:22:54Z urn:sha1:d881836379172f4072ed81ea074f46b3a363a681