dcpomatic/src/lib/atomicity_checker.h, branch mainDCP-o-matic DCP toolshttps://git.carlh.net/cgit/dcpomatic/atom?h=main2020-06-04T23:18:46ZThis AtomicityChecker was introduced a long time ago for reasons2020-06-04T23:18:46ZCarl Hetheringtoncth@carlh.net2020-06-04T23:18:46Zurn:sha1:cc6c991ddd53e2f151140cbadef2da660cd7d6a3
that are unclear.
This commit removes it because it was causing a bug whereby the
_suspended count on Butler would not go back down to 0 due to signals
being blocked by the AtomicityChecker.
I can see two possibilities:
1. AtomicityChecker is a band-aid for some deeper problem, in which
case other bugs will become apparent. Perhaps it relates to signals
being sent before the butler/player/playlist are connected to content.
2. AtomicityChecker was correct but was not identifiying signals
from different pieces of content correctly; so the correct fix would
be to add the content pointer to the _checker.send() call and block
based also on that.
Missing files.2018-12-14T01:10:05ZCarl Hetheringtoncth@carlh.net2018-12-14T01:10:05Zurn:sha1:ac5b373ab1f8d7cbc7b83aa05edec231bc1d956c