dcpomatic/src/lib/butler.cc, branch arbitrary-hzDCP-o-matic DCP toolshttps://git.carlh.net/cgit/dcpomatic/atom?h=arbitrary-hz2025-09-02T20:40:13ZUntested conversion to num/den DCPTime.2025-09-02T20:40:13ZCarl Hetheringtoncth@carlh.net2024-12-21T23:09:57Zurn:sha1:33b0928b20618da5bc295711bfdf3d638863afa5
Summary of required changes:
Replace ::from_frames with a constructor that takes num/den.
Provide and use member to_debug_string() instead of to_string().
Provide and use member to_serializable_string() and string constructor instead of fmt::to_string on .get() and number constructor.
Provide and use content_time() member instead of ContentTime constructor from DCPTime.
Use frames_round(96000) instead of get() when comparing times to see if they are "close enough".
Provide and use DCPTime(x, FrameRateChange) constructor when converting from ContentTime.
Use .seconds() when calculating proportions or sometimes when dividing by HZ.
Provide and use operator bool().
Pass explicit 96000 denominator in a lot of places.
Add member max() and use it instead of static max()
Change BOOST_CHECK_EQUAL to BOOST_CHECK
Provide operator/ and use it instead of .get() / 2.
Remove compose.hpp includes.2025-07-10T18:50:32ZCarl Hetheringtoncth@carlh.net2025-07-09T20:58:37Zurn:sha1:bad01065584014aee4024e7cbc4a66acac7617e1
sed -i "/include.*compose.hpp/d;" src/lib/*.cc src/wx/*.cc src/wx/*.h src/tools/*.cc src/lib/*.h test/*.cc
Replace String::compose with fmt.2025-07-10T18:50:32ZCarl Hetheringtoncth@carlh.net2025-07-09T20:53:27Zurn:sha1:62c34b28567a097e8f22576e7d7891bd3dbe0ac0
sed -i "/Plural-Forms/n;/%100/n;/scanf/n;s/%[123456789]/{}/g" src/lib/*.cc src/lib/*.h src/wx/*.cc src/tools/*.cc src/lib/po/*.po src/wx/po/*.po src/tools/po/*.po test/*.cc
sed -i "s/String::compose */fmt::format/g" src/lib/*.cc src/lib/*.h src/wx/*.cc src/tools/*.cc test/*.cc
Remove functors for choosing pixel format output from make_image().2025-05-26T19:51:18ZCarl Hetheringtoncth@carlh.net2025-05-25T20:16:19Zurn:sha1:df9b4676aba8b941f124b174393988cad21677e1White space: butler.{cc,h}2025-04-16T19:43:14ZCarl Hetheringtoncth@carlh.net2025-04-16T19:43:14Zurn:sha1:21d139a2c3cd33c5a1648e24ee012668e334e879Add abstraction of io_{context,service} and use it as appropriate.2025-03-22T12:29:58ZCarl Hetheringtoncth@carlh.net2025-03-17T00:25:02Zurn:sha1:9dd72fc481349f0b5ce985164441eecfa6485c19Cleanup: use auto.2024-02-19T08:54:43ZCarl Hetheringtoncth@carlh.net2024-02-18T22:34:26Zurn:sha1:41121af9e1eb611ebab1f8e8077dbbc7ab3c421aRemove some more unnecessary use of shared_ptr.2022-10-16T22:10:59ZCarl Hetheringtoncth@carlh.net2022-10-14T22:28:32Zurn:sha1:7d8d78c183656191ff44c9464e06b843bfadc54dFix race between the Butler thread starting and audio (perhaps) being disabled.2022-05-26T18:04:33ZCarl Hetheringtoncth@carlh.net2022-05-26T18:04:33Zurn:sha1:8987f133295e352c44e05ef338eacc801c61a629
This could cause Butler::audio to be called with _audio_channels = 0
and _disable_audio = false, causing an exception in AudioBuffers when
remap() tried to make an AudioBuffers object with a channel count of 0.
C++11 tidying.2022-04-20T20:10:11ZCarl Hetheringtoncth@carlh.net2022-04-16T21:56:06Zurn:sha1:471dee40c1476aba2ff0cff7a57b31306c50b93e