dcpomatic/src/lib/butler.cc, branch benchmarkDCP-o-matic DCP toolshttps://git.carlh.net/cgit/dcpomatic/atom?h=benchmark2020-09-01T14:34:26ZBuild fixes for Boost >= 1.732020-09-01T14:34:26ZCarl Hetheringtoncth@carlh.net2020-08-27T20:37:32Zurn:sha1:c04fec82d25127fafa73c3daff87bece9aa8c8e8
Forward-ported-from: d1e9749ca290673639a49d693a8fe5c6557cc2de
Report better errors when the butler dies.2020-08-17T13:44:58ZCarl Hetheringtoncth@carlh.net2020-08-17T13:44:58Zurn:sha1:6abf2fdd53b14608561fcc1900507daea5b79fb7
Adapted from d23f55d8cd73adda823d0a2fcabc129b8845a81 in master.
Fix bugs in thread termination causing occasional pthread2020-07-29T18:22:54ZCarl Hetheringtoncth@carlh.net2020-07-29T18:22:54Zurn:sha1:e3c7656f9dc0acbaf518c051b847ee2e4eb7ba23
assertion failures.
Before this, it was possible for J2KEncoder::terminate_threads()
to finish without terminating all threads if the thread _running_
terminate_threads() was itself interrupt()ed.
This is because the thread_group::join_all() in terminate_threads()
is an interruption point, so it was possible it not to complete
but instead to throw interrupted_exception. Then the owning
J2KEncoder would be torn down but the threads would still be running,
causing use-after-frees.
This commit adds some boost::this_thread::disable_interruption
objects to ensure that the owning thread is not interrupted while
it is being destroyed.
Also tidy up code that does this stuff, assuming that it's safe
to not call thread::joinable but instead do
thread.interrupt();
try {
thread.join();
} catch (...) {}
Improve butler error reporting during export.2020-07-05T20:10:03ZCarl Hetheringtoncth@carlh.net2020-07-05T20:10:03Zurn:sha1:cfa822570e6f2d2d09fe1c36a81b224ded07c6b6Various thread cleanups.2020-01-30T21:54:38ZCarl Hetheringtoncth@carlh.net2020-01-30T21:54:38Zurn:sha1:ea6b2dae46caa1da829fbf499e83cd6ae3b3773aRemove dubious _buffers_mutex and maintain a lock on _mutex for2019-11-05T20:09:37ZCarl Hetheringtoncth@carlh.net2019-11-05T20:09:37Zurn:sha1:e97d48b043fe39ec22687555225d6b4b526a2172
the whole of ::audio. Otherwise changes to pending seeks can be
mixed up with audio being put into the ringbuffer.
Optimise the feel of some GUI functions by doing the seek after2019-07-24T19:42:50ZCarl Hetheringtoncth@carlh.net2019-07-24T19:42:50Zurn:sha1:335ef709439cd3678f6813a3fb880110e4c9cb26
many content changes in an idle handler, rather than blocking
the UI update until the seek and image redisplay have finished.
Player::playlist_content_change will call setup_pieces() regardless2019-05-15T22:52:15ZCarl Hetheringtoncth@carlh.net2019-05-15T22:52:15Zurn:sha1:c68cf49367957b49a99a9cc04013e9ee5a8c5bfc
of the state of frequent, so Butler::player_change must always seek
regardless of the state of frequent. Otherwise setup_pieces() results
in the next pass() output being at position 0, which causes problems
when the audio from that output is pushed into the audio ring buffers.
Put Time types in dcpomatic namespace.2019-05-10T22:43:55ZCarl Hetheringtoncth@carlh.net2019-05-08T22:41:42Zurn:sha1:c4403784febdbdd42e9c32e67fadb147f11fe566Comment tweaks.2019-04-19T23:29:49ZCarl Hetheringtoncth@carlh.net2019-04-19T23:29:49Zurn:sha1:75ef09f7ca0838357b55399916719655905e218a