dcpomatic/src/lib/butler.cc, branch debug/niclas DCP-o-matic DCP tools https://git.carlh.net/cgit/dcpomatic/atom?h=debug%2Fniclas 2018-02-18T01:28:39Z Hold lock for the whole of Butler::video(). Fixes jumpy nudge-seek 2018-02-18T01:28:39Z Carl Hetherington cth@carlh.net 2018-02-18T01:26:03Z urn:sha1:37252b5a04501c1ba3c27c51d043235046775f78 when playing DCPs. Before, the lock was only held to check _pending_seek_position. With that arrangement, this sequence was possible: 1. video arrives, check _pending_seek_position, decide it's ok, release lock 2. Butler::seek called, sets _pending_seek_position, clears _video 3. video that arrived in #1 is put into _video by ::video() 4. that video is given to an awaiting get_video() call. This clearly subverts the attempts not to accept new video data while a seek is pending. Name threads on Linux. 2018-02-16T20:24:37Z Carl Hetherington cth@carlh.net 2018-02-16T20:24:37Z urn:sha1:8e4a2e5ea578ac4f0f41edb6145d5c0040e33ec2 Tone some debug messages down slightly. 2018-02-12T23:21:34Z Carl Hetherington cth@carlh.net 2018-02-12T23:21:34Z urn:sha1:d7f731ef2a3e099cf7b9af1de514e8b56b71dfa1 Slightly better log message. 2018-02-07T20:14:12Z Carl Hetherington cth@carlh.net 2018-02-07T20:14:12Z urn:sha1:42a6035c187305bd4c541bb1ab87b242b58beb7e Add basic memory-used stuff for butler and reduce minimum audio 2017-12-29T22:51:50Z Carl Hetherington cth@carlh.net 2017-12-29T22:51:50Z urn:sha1:a5ea5c0d2637dd41e3d356cb62cac75b8cadf8ce readahead quite a bit. This in turn reduces the maximum butler memory usage as it will keep getting audio (and hence video) until the minimum audio readahead is hit. Reduce the maximum video readahead. 2017-12-29T20:53:46Z Carl Hetherington cth@carlh.net 2017-12-29T20:53:46Z urn:sha1:440ccee46b4d02e1509686cc63875645fb24254f Attempt to prevent a deadlock if audio is full and video empty (or vice versa). 2017-12-13T22:04:29Z Carl Hetherington cth@carlh.net 2017-12-13T22:04:29Z urn:sha1:7b0af48a5861cb58314db46d29b05289979c2c25 Remove believed-unnecessary player-changed handler in butler. 2017-08-14T20:07:49Z Carl Hetherington cth@carlh.net 2017-08-04T00:28:57Z urn:sha1:9de96c328babc3944f5a9b4d12da9471e3a33ef7 Missing conditional wakeup. 2017-08-14T20:07:49Z Carl Hetherington cth@carlh.net 2017-08-03T22:45:51Z urn:sha1:63d301ca5f4518c2d559066cc7909e7acb62cd7f I think Butler should just clear itself out when the player changes. 2017-08-14T20:07:49Z Carl Hetherington cth@carlh.net 2017-08-03T16:53:13Z urn:sha1:e952a7b0681d1ad2fc6ebcd0cd7231bf59bbe043 Other layers will seek as appropriate, we shouldn't fight them I don't think.