dcpomatic/src/lib/butler.cc, branch disk-optDCP-o-matic DCP toolshttps://git.carlh.net/cgit/dcpomatic/atom?h=disk-opt2021-02-15T09:56:14ZDon't keep returning AGAIN from the butler when it is already dead/finished.2021-02-15T09:56:14ZCarl Hetheringtoncth@carlh.net2021-02-15T01:50:03Zurn:sha1:34119b89c286fc486e9035007066e01462afb8c3
This causes, for example, player UI hangs when trying to play
something unplayable (e.g. a DCP with no KDM).
More enum class additions.2021-01-31T02:14:24ZCarl Hetheringtoncth@carlh.net2021-01-31T02:14:24Zurn:sha1:8fedaaa75c4586a4cc7ffb393bd71d1fdb091dc8std::shared_ptr2021-01-07T21:48:29ZCarl Hetheringtoncth@carlh.net2021-01-04T20:16:53Zurn:sha1:dd9be86db6cde0afa5da0d1d1ac43b42e05dca26Changes to crop can be handled with a reset_metadata().2020-12-01T10:32:36ZCarl Hetheringtoncth@carlh.net2020-12-01T10:32:36Zurn:sha1:be2e6e017d853069f02a83f5fe67423235c3096c
While playback is happening we need to do that in the butler's
buffers and in the little delay inside Player.
This removes the seek on every crop change, making it a lot
quicker (#1758).
Give Butler a weak_ptr<Film>2020-11-30T23:20:51ZCarl Hetheringtoncth@carlh.net2020-11-30T22:49:04Zurn:sha1:5b6b01ea778064a0b0125ea8ebd9272a534cccd2Make sure we use limited ("video") range data when exporting.2020-11-16T00:40:36ZCarl Hetheringtoncth@carlh.net2020-11-15T19:47:42Zurn:sha1:b057363e69b77119137c0c8b07402828096e03aa
Our export formats all currently use limited range but we weren't
making sure data fed to the encoders was limited range.
Should fix #1832.
Build fixes for Boost >= 1.732020-09-01T14:34:26ZCarl Hetheringtoncth@carlh.net2020-08-27T20:37:32Zurn:sha1:c04fec82d25127fafa73c3daff87bece9aa8c8e8
Forward-ported-from: d1e9749ca290673639a49d693a8fe5c6557cc2de
Report better errors when the butler dies.2020-08-17T13:44:58ZCarl Hetheringtoncth@carlh.net2020-08-17T13:44:58Zurn:sha1:6abf2fdd53b14608561fcc1900507daea5b79fb7
Adapted from d23f55d8cd73adda823d0a2fcabc129b8845a81 in master.
Fix bugs in thread termination causing occasional pthread2020-07-29T18:22:54ZCarl Hetheringtoncth@carlh.net2020-07-29T18:22:54Zurn:sha1:e3c7656f9dc0acbaf518c051b847ee2e4eb7ba23
assertion failures.
Before this, it was possible for J2KEncoder::terminate_threads()
to finish without terminating all threads if the thread _running_
terminate_threads() was itself interrupt()ed.
This is because the thread_group::join_all() in terminate_threads()
is an interruption point, so it was possible it not to complete
but instead to throw interrupted_exception. Then the owning
J2KEncoder would be torn down but the threads would still be running,
causing use-after-frees.
This commit adds some boost::this_thread::disable_interruption
objects to ensure that the owning thread is not interrupted while
it is being destroyed.
Also tidy up code that does this stuff, assuming that it's safe
to not call thread::joinable but instead do
thread.interrupt();
try {
thread.join();
} catch (...) {}
Improve butler error reporting during export.2020-07-05T20:10:03ZCarl Hetheringtoncth@carlh.net2020-07-05T20:10:03Zurn:sha1:cfa822570e6f2d2d09fe1c36a81b224ded07c6b6