dcpomatic/src/lib/butler.cc, branch v2.13.41 DCP-o-matic DCP tools https://git.carlh.net/cgit/dcpomatic/atom?h=v2.13.41 2018-08-05T00:15:45Z Get closed caption view data from the butler, rather than the player. 2018-08-05T00:15:45Z Carl Hetherington cth@carlh.net 2018-08-05T00:15:45Z urn:sha1:3a7b6acdb993864f319a6ceb3bc4c3fb7d4aaefd You can't introduce the butler (so that the player is ahead of time) and then ask the player what should be in the frame that is being displayed "now"; the player will already have moved on. Remove unused parameter. 2018-08-03T23:18:22Z Carl Hetherington cth@carlh.net 2018-08-03T23:18:22Z urn:sha1:984455f1a072b0fa42879d03042e82df0a3cb3bd Timestamp audio emissions from butler and hence discard very late 2018-08-03T23:01:30Z Carl Hetherington cth@carlh.net 2018-08-03T23:01:30Z urn:sha1:54e6f206305d4275808cfce36987edcc61a6a779 audio in FilmViewer. This should help with the case where lots of video frames are rapidly discarded when they are late but the corresponding audio is not, hence audio buffers get overfilled. A variety of changes to improve (but not entirely fix) behaviour 2018-08-02T22:22:49Z Carl Hetherington cth@carlh.net 2018-08-02T22:22:49Z urn:sha1:4fe1a062eb31d680b8b4ac0191b9e2fc2d6aaec3 when moving content (or otherwise changing the playlist) while playing. This commit refills the butler when things change in certain ways, and improves locking to cope with Player methods being called from the GUI and butler threads at the same time. Remove debug code. 2018-07-27T15:21:21Z Carl Hetherington cth@carlh.net 2018-07-27T15:21:21Z urn:sha1:1e0425dc769a0a909d20de7af373bff3f38de8d2 Protect the public API of Player with a mutex, since 2018-07-26T19:59:04Z Carl Hetherington cth@carlh.net 2018-07-26T19:59:04Z urn:sha1:3009a585f5222a83213c786e3c564c740f450d18 seek() and pass() may be called from the Butler thread ad the same time as other Player methods are called from the GUI thread (by FilmViewer and ClosedCaptionViewDialog). Add some timing logs for playback. 2018-06-22T00:06:49Z Carl Hetherington cth@carlh.net 2018-06-22T00:06:49Z urn:sha1:3f8e7d70bb81890246f9cea54cbc494b027dcc53 Throw exceptions when things in the butler get really out of hand. 2018-06-11T11:22:46Z Carl Hetherington cth@carlh.net 2018-06-11T11:22:46Z urn:sha1:9d72b829d65462cdcf7c0e267181ea814ad37071 Hold lock for the whole of Butler::video(). Fixes jumpy nudge-seek 2018-02-18T01:28:39Z Carl Hetherington cth@carlh.net 2018-02-18T01:26:03Z urn:sha1:37252b5a04501c1ba3c27c51d043235046775f78 when playing DCPs. Before, the lock was only held to check _pending_seek_position. With that arrangement, this sequence was possible: 1. video arrives, check _pending_seek_position, decide it's ok, release lock 2. Butler::seek called, sets _pending_seek_position, clears _video 3. video that arrived in #1 is put into _video by ::video() 4. that video is given to an awaiting get_video() call. This clearly subverts the attempts not to accept new video data while a seek is pending. Name threads on Linux. 2018-02-16T20:24:37Z Carl Hetherington cth@carlh.net 2018-02-16T20:24:37Z urn:sha1:8e4a2e5ea578ac4f0f41edb6145d5c0040e33ec2