dcpomatic/src/lib/butler.cc, branch v2.13.44 DCP-o-matic DCP tools https://git.carlh.net/cgit/dcpomatic/atom?h=v2.13.44 2018-08-20T11:01:34Z Allow nested butler suspensions. 2018-08-20T11:01:34Z Carl Hetherington cth@carlh.net 2018-08-20T11:01:34Z urn:sha1:a638a231d1cf8d04840b62354911520dab6fb6b3 Replace May/Done/NotDone signal sets with one signal and extend 2018-08-19T00:29:04Z Carl Hetherington cth@carlh.net 2018-08-19T00:04:59Z urn:sha1:6c7489e5d778d3e71065d88a094a7383ba2c117d this treatment to anything that caused Player::setup_pieces. This should fix out-of-sequence Player emissions caused by setup_pieces being called by one thread while the butler is calling pass(). Suspend butler on player may-change as otherwise there's a window 2018-08-19T00:29:04Z Carl Hetherington cth@carlh.net 2018-08-18T21:49:46Z urn:sha1:9a27d60ea7888d300a5a2414a477091428589b82 between Player::_suspended being set to false and the the butler requesting a seek, during which the butler may call pass(). More fixes for errors / crashes / misbehaviour with content changes 2018-08-13T23:05:06Z Carl Hetherington cth@carlh.net 2018-08-13T16:37:52Z urn:sha1:1fe6bd7f8ba059322b8357b2210f0fd590567ce2 and the butler. Here we signal both before and after a change in content. Before, the player disables itself so that any pass()/seek() will be no-ops. After, the player rebuilds its pieces and the butler re-seeks to get back to where it was before the change. Don't seek during timeline drags. 2018-08-12T21:02:25Z Carl Hetherington cth@carlh.net 2018-08-12T21:02:25Z urn:sha1:b733ff51f0212d02dbf33ccb62e67f07941f5ace Remove duplicated stuff from seek_unlocked(); tweak some ordering. 2018-08-09T21:31:11Z Carl Hetherington cth@carlh.net 2018-08-08T23:01:49Z urn:sha1:52094ba65baa38dfcedc907cfb4314efb1a549b4 Get closed caption view data from the butler, rather than the player. 2018-08-05T00:15:45Z Carl Hetherington cth@carlh.net 2018-08-05T00:15:45Z urn:sha1:3a7b6acdb993864f319a6ceb3bc4c3fb7d4aaefd You can't introduce the butler (so that the player is ahead of time) and then ask the player what should be in the frame that is being displayed "now"; the player will already have moved on. Remove unused parameter. 2018-08-03T23:18:22Z Carl Hetherington cth@carlh.net 2018-08-03T23:18:22Z urn:sha1:984455f1a072b0fa42879d03042e82df0a3cb3bd Timestamp audio emissions from butler and hence discard very late 2018-08-03T23:01:30Z Carl Hetherington cth@carlh.net 2018-08-03T23:01:30Z urn:sha1:54e6f206305d4275808cfce36987edcc61a6a779 audio in FilmViewer. This should help with the case where lots of video frames are rapidly discarded when they are late but the corresponding audio is not, hence audio buffers get overfilled. A variety of changes to improve (but not entirely fix) behaviour 2018-08-02T22:22:49Z Carl Hetherington cth@carlh.net 2018-08-02T22:22:49Z urn:sha1:4fe1a062eb31d680b8b4ac0191b9e2fc2d6aaec3 when moving content (or otherwise changing the playlist) while playing. This commit refills the butler when things change in certain ways, and improves locking to cope with Player methods being called from the GUI and butler threads at the same time.