dcpomatic/src/lib/dcp_video.cc, branch deb13DCP-o-matic DCP toolshttps://git.carlh.net/cgit/dcpomatic/atom?h=deb132025-08-12T15:16:07ZNew/improved pixel format decision when converting to XYZ.2025-08-12T15:16:07ZCarl Hetheringtoncth@carlh.net2025-07-21T22:48:42Zurn:sha1:98a8023dd774fd82c144a68039e0ea3131fb9142
For a long time we would keep XYZ12LE, if that's what we have, otherwise
ask FFmpeg to switch to RGB48LE.
Then in 1d5c211dadb9a9dc2318adce86ca9c31b367cabe I tried to fix the case
of an XYZ source mis-tagged as YUV. I changed things so that with no
colour conversion we'd always ask FFmpeg to convert to XYZ. This meant
that RGB sources with no colour conversion would get treatment by FFmpeg
due to the RGB -> XYZ switch.
Here we're going back to the more-or-less the "long time" behaviour when
there is a conversion (keep XYZ12LE but otherwise convert to RGB48).
When there's no conversion, keep RGB (to avoid the FFmpeg conversion
from RGB -> XYZ) but convert everything else to XYZ.
Replace AVPixelFormat parameter to PlayerVideo::image with a functor.2025-08-12T15:16:07ZCarl Hetheringtoncth@carlh.net2025-07-21T22:18:32Zurn:sha1:9b73c143ce568bd8694e3a50f2fefc1ee3a03515
This was removed in df9b4676aba8b941f124b174393988cad21677e1 and
surrounding commits, but it turns out we need it after all.
Remove compose.hpp includes.2025-07-10T18:50:32ZCarl Hetheringtoncth@carlh.net2025-07-09T20:58:37Zurn:sha1:bad01065584014aee4024e7cbc4a66acac7617e1
sed -i "/include.*compose.hpp/d;" src/lib/*.cc src/wx/*.cc src/wx/*.h src/tools/*.cc src/lib/*.h test/*.cc
Replace String::compose with fmt.2025-07-10T18:50:32ZCarl Hetheringtoncth@carlh.net2025-07-09T20:53:27Zurn:sha1:62c34b28567a097e8f22576e7d7891bd3dbe0ac0
sed -i "/Plural-Forms/n;/%100/n;/scanf/n;s/%[123456789]/{}/g" src/lib/*.cc src/lib/*.h src/wx/*.cc src/tools/*.cc src/lib/po/*.po src/wx/po/*.po src/tools/po/*.po test/*.cc
sed -i "s/String::compose */fmt::format/g" src/lib/*.cc src/lib/*.h src/wx/*.cc src/tools/*.cc test/*.cc
Remove functors for choosing pixel format output from make_image().2025-05-26T19:51:18ZCarl Hetheringtoncth@carlh.net2025-05-25T20:16:19Zurn:sha1:df9b4676aba8b941f124b174393988cad21677e1Remove last use of keep_xyz_or_rgb.2025-05-26T19:51:18ZCarl Hetheringtoncth@carlh.net2025-05-25T20:03:30Zurn:sha1:e444fbd0d7c8a32e9f50adc19d0d49ae7c489a11Ensure that XYZ data is not passed to rgb_to_xyz() when using Grok.2025-05-26T19:51:18ZCarl Hetheringtoncth@carlh.net2025-05-23T00:46:47Zurn:sha1:06f359d678b8782a7f599c0a3f41b7c8282efcd9Fix incorrect colours with "no colourspace conversion" sources that are not AV_PIX_FMT_XYZ12LE.2025-05-26T19:51:18ZCarl Hetheringtoncth@carlh.net2025-05-22T23:23:43Zurn:sha1:1d5c211dadb9a9dc2318adce86ca9c31b367cabe
Prepare the image for where it is going to next. I don't understand the difference
in this situation between XYZ12LE and RGB48LE (it seems they are both 16-bit-per-channel)
but there you go.
White space: dcp_video.{cc,h}2025-04-25T21:11:07ZCarl Hetheringtoncth@carlh.net2025-04-25T21:11:07Zurn:sha1:4803d2339a953f78b898f1c56c5c4f232f34ea8cMake the Socket connect() call a little friendlier.2025-03-22T12:29:58ZCarl Hetheringtoncth@carlh.net2025-03-17T19:27:47Zurn:sha1:169c47ede14b6e86e054871a56ffa048357b4463
This avoids some boilerplate.