dcpomatic/src/lib/file_group.cc, branch debug-corruption DCP-o-matic DCP tools https://git.carlh.net/cgit/dcpomatic/atom?h=debug-corruption 2024-10-19T13:20:58Z Log/hash data coming out of FileGroup. 2024-10-19T13:20:58Z Carl Hetherington cth@carlh.net 2024-10-19T13:20:58Z urn:sha1:fa1d847967f8189ba28db83bd1e38e49bfd8428a Fix stupid bug introduced in 5db3eda9c6f0 2024-09-11T21:08:32Z Carl Hetherington cth@carlh.net 2024-09-11T21:08:32Z urn:sha1:179e362688a5a533f771942cde5126c0b11c7d08 Fix a few places where we should use dcp::File::open_error() 2024-09-03T15:55:19Z Carl Hetherington cth@carlh.net 2024-09-03T15:55:11Z urn:sha1:4049ec5e8bdddbc48689521a26bf47236c2b490d to get a more accurate error number on Windows. Fix confusion about operator bool() with optional. 2024-09-03T15:55:19Z Carl Hetherington cth@carlh.net 2024-09-03T15:53:24Z urn:sha1:5db3eda9c6f0d6b027263c519000997677253504 I think previously no exception would be thrown even if the file weren't open. Use dcp::filesystem to wrap filesystem calls and fix_long_path 2023-10-09T21:38:28Z Carl Hetherington cth@carlh.net 2023-10-06T00:37:16Z urn:sha1:96f50dd5e600925488fdd9db1580aa01b026269b anything that is passed to read_file() from libcxml. This should fix #2623 and other similar problems. Return AVERROR_EOF from the avio_read method when appropriate. 2022-11-25T23:09:27Z Carl Hetherington cth@carlh.net 2022-10-01T18:11:40Z urn:sha1:bc6fd8c020ad27c86c463876f76c8add042cb660 Use dcp::File in DCP-o-matic (#2231). 2022-05-05T21:38:41Z Carl Hetherington cth@carlh.net 2022-04-16T20:20:54Z urn:sha1:8a8c977c12fc65f1f50ea05099387e0fc8840e7d C++11 tidying. 2021-04-30T23:31:35Z Carl Hetherington cth@carlh.net 2021-04-30T23:31:35Z urn:sha1:8963f0007af1a312017b9627c18b82ec2a577591 Fix over-read behaviour of FileGroup to be the same on all platforms. 2020-11-28T19:58:56Z Carl Hetherington cth@carlh.net 2020-11-27T22:30:13Z urn:sha1:cf26869c2789b7ecf91e486fc3c7bf271276a592 Instead of relying on the operating system's behaviour when seeking off the end of a file, keep our own _position. This normalises the behaviour between POSIX and Windows. Fix the behaviour of FileGroup when seeking too far. 2020-11-24T22:01:04Z Carl Hetherington cth@carlh.net 2020-11-24T22:01:04Z urn:sha1:8a1da1da65ba0e6a6fb915c73ff6e6a81da349f2 Previously, if you did a seek off the end of the file group, the seek would return an error. This is not what fseek() does; it returns no error, and preserves the file pointer (returned by ftell()) as if the seek had been successful. fread()s after a too-far seek return no data, of course. Parsing some files (the example used to find the bug was a H264 MP4) involves a seek which is to the byte after the end of the mp4 file. If this fails the whole header parsing fails and DCP-o-matic refuses to use the file.