dcpomatic/src/lib/image.cc, branch video-range-bugDCP-o-matic DCP toolshttps://git.carlh.net/cgit/dcpomatic/atom?h=video-range-bug2022-08-11T21:48:40ZFix video range in preview and DCP when source is VIDEO rather than FULL.2022-08-11T21:48:40ZCarl Hetheringtoncth@carlh.net2022-08-11T21:42:01Zurn:sha1:2e607b7968a0af94d7e38fb9d7d5459e33beed85
It looks like the handling of "video" range (16-235) sources (when
creating "full" range (0-255) outputs) has been broken for some considerable
time. Full range outputs are used for both preview and DCP creation.
We assumed that after we called sws_setColorspaceDetails FFmpeg would take
care of the conversion from video to full, but its source suggests that
it refuses to convert to full-range RGB (only full-range YUV or
greyscale). Previously there was a seemingly correct comment (that
FFmpeg would do nothing if source _or_ destination were RGB) but the
check on when to use video_range_to_full_range() was only activated
for RGB sources, not (also) RGB outputs.
It's hard to believe that this has been around unnoticed for so long.
https://dcpomatic.com/forum/viewtopic.php?t=1928&start=10 has a
discussion which pointed out the problem.
Fix d881836379172f4072ed81ea074f46b3a363a681 which removed clearing2022-08-11T14:39:03ZCarl Hetheringtoncth@carlh.net2022-08-11T14:39:03Zurn:sha1:f2b10879dcafccdb28f88d53dc1fc22094b96c1d
of the left-hand-side of images.
Fix lines down the right-hand-side of exports in some cases.2022-08-08T22:09:30ZCarl Hetheringtoncth@carlh.net2022-07-26T13:22:54Zurn:sha1:d881836379172f4072ed81ea074f46b3a363a681Fix incorrect burnt-in subtitle colours when burning into a DCP source (#2261).2022-06-10T21:04:54ZCarl Hetheringtoncth@carlh.net2022-06-10T21:04:54Zurn:sha1:9704833bdfc8c8f104203200be27f714fa677506
dcp::combined_rgb_to_xyz was changed in libdcp (the values are no longer scaled
by 65535) but DoM wasn't changed, and there was no test to catch it.
Update for change to libdcp API.2022-05-05T21:06:05ZCarl Hetheringtoncth@carlh.net2022-05-05T21:06:05Zurn:sha1:58d89ba0632d94504b15dc10cb4e4153808f8efeMove Image::as_png() out to image_as_png().2022-04-28T22:11:17ZCarl Hetheringtoncth@carlh.net2021-12-18T20:26:05Zurn:sha1:7ec6c86c913fba820870565ee757fdf43ae47433Remove unnecessary method.2022-04-28T22:09:58ZCarl Hetheringtoncth@carlh.net2021-12-18T20:05:54Zurn:sha1:4673b12dcf6340862f9f4f72fc6dca8553130b55Use libdcp's warnings.h2022-04-22T21:27:15ZCarl Hetheringtoncth@carlh.net2022-04-22T21:27:15Zurn:sha1:3c29aa6531a4046a8db72dcac81189eb8893233cCleanup: move some methods from util to memory_util.2022-04-04T21:09:10ZCarl Hetheringtoncth@carlh.net2022-01-24T21:30:52Zurn:sha1:8eb951b71fa90e54c8da64e54cf5ddf6bf0809cfCleanup: move some methods from util to maths_util.2022-04-04T20:37:31ZCarl Hetheringtoncth@carlh.net2022-04-04T20:37:31Zurn:sha1:cf2ed48d21ddbc32bda262064480e88e69dc031a