dcpomatic/src/lib/player.cc, branch boost-exception-test DCP-o-matic DCP tools https://git.carlh.net/cgit/dcpomatic/atom?h=boost-exception-test 2020-01-28T22:23:47Z Fix deadlock during content examination. 2020-01-28T22:23:47Z Carl Hetherington cth@carlh.net 2020-01-28T22:23:47Z urn:sha1:df48c75c38dd788835a93540aea243a2dac4bb10 Before this fix, the following situation could happen in threads A and B: A: Some DONE signal happens; this triggers setup_pieces which takes a lock on the player mutex. B: FFmpegContent::examine takes a lock on the content mutex. B: FFmpegContent::examine adds a stream B: That causes STREAMS PENDING to be emitted. B: This tries to take a lock on the player mutex so it can update _suspended A: setup_pieces tries to access some content information, hence tries to take a lock on the content mutex. Now B is holding the CL and awaiting the PL and A is holding the PL and awaiting the CL. It feels like the root cause of this is that while setup_pieces is happening another change (which would itself cause setup_pieces) is announced, and this isn't dealt with properly. There are two steps here; _suspended is protected with an atomic rather than using _mutex, and also it can cope with being updated recursively. Cache film length for Player::pass. 2020-01-25T00:47:00Z Carl Hetherington cth@carlh.net 2019-07-23T21:55:15Z urn:sha1:af0edaf7dcd36c367cb585c98e8413c5347a7386 Extend the amount of allowed disagreement between the audio 2020-01-07T13:40:33Z Carl Hetherington cth@carlh.net 2020-01-07T12:30:56Z urn:sha1:77c30a110a321b3b69259381a7f30c5c25f4da7c coming from the content and the calculated periods of silence. It sees that there is some scope for disagreements here when trim start/end times are rounded to frame boundaries. Fixes #1708. Fix comment. 2019-11-11T13:15:19Z Carl Hetherington cth@carlh.net 2019-11-11T13:15:05Z urn:sha1:c247a1b81b78164acf84f4b003062fab25e64b53 Increase fudge factor at the boundary between audio signal and silence. 2019-11-01T10:25:20Z Carl Hetherington cth@carlh.net 2019-11-01T10:25:20Z urn:sha1:1b81a1ee7c4eba533fd49939f8e76744f94038b6 Add a warning log when an assertion gets hit. 2019-09-19T22:35:08Z Carl Hetherington cth@carlh.net 2019-09-19T22:11:25Z urn:sha1:400e34c23ba9ec240358cd028f90fba38bbf1560 Forward-ported from 4141f01e25abd5050db09ff85da47ff059909669 in master. Stop crashing when running the hints check on films with silent/black gaps. 2019-09-09T00:18:54Z Carl Hetherington cth@carlh.net 2019-09-09T00:18:54Z urn:sha1:1bfc60e40f533c6d931a915deabd97899719eb4b Primitive subtitle export feature. 2019-08-31T01:03:01Z Carl Hetherington cth@carlh.net 2019-08-31T01:03:01Z urn:sha1:2cdf3d9f461b12d0925cc54368105bbd177bbbb3 Make player more tolerant of some DCP errors. 2019-08-30T22:16:21Z Carl Hetherington cth@carlh.net 2019-08-30T22:16:21Z urn:sha1:1f88a38a2a607c21988a403e76f315444c4be36b Avoid random black gaps between bits of content A and B when 2019-07-30T23:07:06Z Carl Hetherington cth@carlh.net 2019-07-30T23:07:06Z urn:sha1:bd83f1b0e1d8e7aae0af51376dbbb88d5e3f69d0 content B has had its start trimmed. In this case when we seek inaccurately in A we previously also seeked inaccurately in B. This meant that at the transition the first frame we see of B may not be the first frame of B. After this we seek accurately in B so that we definitely get to the start of it. This is especially important if the start of B has been trimmed to within two keyframes so that an inaccurate seek is not sufficient.