dcpomatic/src/lib/player_video.cc, branch processor

Return quite close to original approach for "no colour conversion".

2025-09-23T07:14:10Z

There's a few things going on here: 1. Improve the regression test for 3042. Previously we made a DCP from the reporter's _original_ prores file (before they converted it to XYZ) and compared the result to a reference J2K file of uncertain origin. This seems wrong because: a) We never got confirmation from the reporter that the fix worked for them, so any arbitrary reference is dubious. b) It doesn't seem to reflect their actual complaint, which was that they got a different result when making a DCP from XYZ TIFFs compared to their "XYZ" Prores. The new test makes a DCP from their TIFFs and "XYZ" Prores and compares the result. 2. Revert to the old approach to "no conversion" handling. In the good old days we did everything -> RGB48LE except XYZ12LE -> XYZ12LE, and that's what we do again here. 3. Change the YUV->RGB conversion from Rec.601 to Rec.709 for the "no conversion" case. This fixes the 3042 regression test. The supposed "XYZ" Prores is yuv444p12le according to ffprobe. So I think what we have here is actually a file that was converted to XYZ and then back to YUV by Resolve. I experimented with using the raw YUV values and considering them as XYZ but this was clearly wrong. I think 3 is probably what I should have done in the first place.

Replace AVPixelFormat parameter to PlayerVideo::image with a functor.

2025-08-12T15:16:07Z

This was removed in df9b4676aba8b941f124b174393988cad21677e1 and surrounding commits, but it turns out we need it after all.

White space: player_video.{cc,h} reel_writer.{cc,h} maths_util.{cc,h} upmixer_{a,b}.{cc,h} upload_job.{cc,h}

2025-07-01T18:17:25Z

Remove functors for choosing pixel format output from make_image().

2025-05-26T19:51:18Z

Bump libdcp for raw_convert changes.

2025-01-05T11:58:13Z

raw_convert is gone, so here we use fmt::{to_string,format} instead. Other raw_converts now use fast_float.

Remove all use of add_child() from xmlpp.

2024-03-20T17:25:09Z

Merge tag 'v2.16.78' into v2.17.x

2024-02-22T00:25:03Z

Make DCPExaminer::size() optional and deal with the consequences.

2024-02-21T17:48:53Z

This means we can fix the case of a VF having no known size in a nice way, in turn fixing problems caused by the fix to #2775.

Change how video timing is done.

2024-01-28T01:01:56Z

This commit changes the approach with video timing. Previously, we would (more-or-less) try to use every video frame from the content in the output, hoping that they come at a constant frame rate. This is not always the case, however. Here we preserve the PTS of video frames, and then when one arrives we output whatever DCP video frames we can (at the regular DCP frame rate). Hopefully this will solve a range of sync problems, but it could also introduce new ones.

Cleanup: remove unused parameter to PlayerVideo::force.

2022-04-07T20:13:11Z