dcpomatic/src/lib/playlist.cc, branch xml-test DCP-o-matic DCP tools https://git.carlh.net/cgit/dcpomatic/atom?h=xml-test 2020-06-04T23:18:46Z This AtomicityChecker was introduced a long time ago for reasons 2020-06-04T23:18:46Z Carl Hetherington cth@carlh.net 2020-06-04T23:18:46Z urn:sha1:cc6c991ddd53e2f151140cbadef2da660cd7d6a3 that are unclear. This commit removes it because it was causing a bug whereby the _suspended count on Butler would not go back down to 0 due to signals being blocked by the AtomicityChecker. I can see two possibilities: 1. AtomicityChecker is a band-aid for some deeper problem, in which case other bugs will become apparent. Perhaps it relates to signals being sent before the butler/player/playlist are connected to content. 2. AtomicityChecker was correct but was not identifiying signals from different pieces of content correctly; so the correct fix would be to add the content pointer to the _checker.send() call and block based also on that. Naming tweak. 2020-01-08T20:56:47Z Carl Hetherington cth@carlh.net 2019-11-19T16:13:25Z urn:sha1:73713b742a2be95ea736d2d3d889f5b535a0f0f1 Clean up access to stuff from Film. 2020-01-08T20:56:47Z Carl Hetherington cth@carlh.net 2019-11-19T16:07:35Z urn:sha1:86a866d5f3f5bf2fec67d1c813524479c6727eab Put Time types in dcpomatic namespace. 2019-05-10T22:43:55Z Carl Hetherington cth@carlh.net 2019-05-08T22:41:42Z urn:sha1:c4403784febdbdd42e9c32e67fadb147f11fe566 Fix locking of Playlist to protect against access from the GUI thread 2019-03-13T10:59:47Z Carl Hetherington cth@carlh.net 2019-03-13T10:59:47Z urn:sha1:a1a96da90403c0a16a9d9dcde9fd8b66da2daffe and at the same time traces like Butler -> Content::end -> Playlist::active_frame_rate_change. Suggest that DCP rates <= 30 are used unless the user explictly goes higher (#1441). 2019-01-26T22:44:08Z Carl Hetherington cth@carlh.net 2019-01-26T22:44:08Z urn:sha1:078a0f98e3f741210be7f839292f41f28b6a403e swaroop: fix up restart-after-crash. 2018-12-14T00:58:48Z Carl Hetherington cth@carlh.net 2018-12-14T00:58:48Z urn:sha1:ed227b4fdba9b4fc7f06f6db4830219f14bad358 Remove Film pointer from clone(). 2018-11-21T22:25:43Z Carl Hetherington cth@carlh.net 2018-11-21T22:25:43Z urn:sha1:fe8251bb73765b459042b0fa841dae2d440487fd Take Film pointer out of Content. 2018-11-21T01:59:04Z Carl Hetherington cth@carlh.net 2018-11-21T01:59:04Z urn:sha1:254b3044d72de6b033d7c584f5abd2b9aa70aad5 Replace May/Done/NotDone signal sets with one signal and extend 2018-08-19T00:29:04Z Carl Hetherington cth@carlh.net 2018-08-19T00:04:59Z urn:sha1:6c7489e5d778d3e71065d88a094a7383ba2c117d this treatment to anything that caused Player::setup_pieces. This should fix out-of-sequence Player emissions caused by setup_pieces being called by one thread while the butler is calling pass().