<feed xmlns='http://www.w3.org/2005/Atom'>
<title>dcpomatic/src/lib/playlist.h, branch bisect</title>
<subtitle>DCP-o-matic DCP tools</subtitle>
<id>https://git.carlh.net/cgit/dcpomatic/atom?h=bisect</id>
<link rel='self' href='https://git.carlh.net/cgit/dcpomatic/atom?h=bisect'/>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/'/>
<updated>2024-04-21T21:18:23Z</updated>
<entry>
<title>Rename j2k_bandwidth -&gt; video_bit_rate.</title>
<updated>2024-04-21T21:18:23Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2024-04-05T19:57:03Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=c98d6fd22da1586ef3c1d64a2f7b1ee602f539e9'/>
<id>urn:sha1:c98d6fd22da1586ef3c1d64a2f7b1ee602f539e9</id>
<content type='text'>
</content>
</entry>
<entry>
<title>Remove all use of add_child() from xmlpp.</title>
<updated>2024-03-20T17:25:09Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2024-02-06T09:58:39Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=0e5013e1a96af81e4b501ff0c3192c10a061a2c8'/>
<id>urn:sha1:0e5013e1a96af81e4b501ff0c3192c10a061a2c8</id>
<content type='text'>
</content>
</entry>
<entry>
<title>Move ContentSorter out of the header, and use a default constructor.</title>
<updated>2023-08-09T08:18:46Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2023-08-08T16:32:03Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=280568029622c5e99d4b90d55b0cebe12cb24e93'/>
<id>urn:sha1:280568029622c5e99d4b90d55b0cebe12cb24e93</id>
<content type='text'>
</content>
</entry>
<entry>
<title>Clarify comment.</title>
<updated>2023-02-10T09:31:15Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2023-02-09T21:16:36Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=a8e22f49504701e9dc50df2b2da7b7ebaa4cb859'/>
<id>urn:sha1:a8e22f49504701e9dc50df2b2da7b7ebaa4cb859</id>
<content type='text'>
</content>
</entry>
<entry>
<title>Extract constants.h</title>
<updated>2022-12-09T23:47:30Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2022-12-09T23:47:30Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=da38c8a0156808595be0aae1b1490069a663fb78'/>
<id>urn:sha1:da38c8a0156808595be0aae1b1490069a663fb78</id>
<content type='text'>
</content>
</entry>
<entry>
<title>Comment fixes.</title>
<updated>2021-06-13T18:28:17Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2021-06-13T18:28:17Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=1284c2d02a367afaeb18acc2138293e8bdf724ae'/>
<id>urn:sha1:1284c2d02a367afaeb18acc2138293e8bdf724ae</id>
<content type='text'>
</content>
</entry>
<entry>
<title>C++11 tidying.</title>
<updated>2021-02-16T09:40:12Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2021-02-16T09:40:12Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=bb949ec65adf95f4a2c7dd5ee7e97b9daaaf3d3f'/>
<id>urn:sha1:bb949ec65adf95f4a2c7dd5ee7e97b9daaaf3d3f</id>
<content type='text'>
</content>
</entry>
<entry>
<title>Use enum class for Film::Property.</title>
<updated>2021-01-31T22:47:14Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2021-01-31T22:47:14Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=e0255a64d22440d718e5512f34a4f21f0d37a21b'/>
<id>urn:sha1:e0255a64d22440d718e5512f34a4f21f0d37a21b</id>
<content type='text'>
</content>
</entry>
<entry>
<title>std::shared_ptr</title>
<updated>2021-01-07T21:48:29Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2021-01-04T20:16:53Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=dd9be86db6cde0afa5da0d1d1ac43b42e05dca26'/>
<id>urn:sha1:dd9be86db6cde0afa5da0d1d1ac43b42e05dca26</id>
<content type='text'>
</content>
</entry>
<entry>
<title>This AtomicityChecker was introduced a long time ago for reasons</title>
<updated>2020-06-04T23:18:46Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2020-06-04T23:18:46Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=cc6c991ddd53e2f151140cbadef2da660cd7d6a3'/>
<id>urn:sha1:cc6c991ddd53e2f151140cbadef2da660cd7d6a3</id>
<content type='text'>
that are unclear.

This commit removes it because it was causing a bug whereby the
_suspended count on Butler would not go back down to 0 due to signals
being blocked by the AtomicityChecker.

I can see two possibilities:

1. AtomicityChecker is a band-aid for some deeper problem, in which
case other bugs will become apparent.  Perhaps it relates to signals
being sent before the butler/player/playlist are connected to content.

2. AtomicityChecker was correct but was not identifiying signals
from different pieces of content correctly; so the correct fix would
be to add the content pointer to the _checker.send() call and block
based also on that.
</content>
</entry>
</feed>
