<feed xmlns='http://www.w3.org/2005/Atom'>
<title>dcpomatic/src/lib/playlist.h, branch fix-tests</title>
<subtitle>DCP-o-matic DCP tools</subtitle>
<id>https://git.carlh.net/cgit/dcpomatic/atom?h=fix-tests</id>
<link rel='self' href='https://git.carlh.net/cgit/dcpomatic/atom?h=fix-tests'/>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/'/>
<updated>2021-06-13T18:28:17Z</updated>
<entry>
<title>Comment fixes.</title>
<updated>2021-06-13T18:28:17Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2021-06-13T18:28:17Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=1284c2d02a367afaeb18acc2138293e8bdf724ae'/>
<id>urn:sha1:1284c2d02a367afaeb18acc2138293e8bdf724ae</id>
<content type='text'>
</content>
</entry>
<entry>
<title>C++11 tidying.</title>
<updated>2021-02-16T09:40:12Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2021-02-16T09:40:12Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=bb949ec65adf95f4a2c7dd5ee7e97b9daaaf3d3f'/>
<id>urn:sha1:bb949ec65adf95f4a2c7dd5ee7e97b9daaaf3d3f</id>
<content type='text'>
</content>
</entry>
<entry>
<title>Use enum class for Film::Property.</title>
<updated>2021-01-31T22:47:14Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2021-01-31T22:47:14Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=e0255a64d22440d718e5512f34a4f21f0d37a21b'/>
<id>urn:sha1:e0255a64d22440d718e5512f34a4f21f0d37a21b</id>
<content type='text'>
</content>
</entry>
<entry>
<title>std::shared_ptr</title>
<updated>2021-01-07T21:48:29Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2021-01-04T20:16:53Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=dd9be86db6cde0afa5da0d1d1ac43b42e05dca26'/>
<id>urn:sha1:dd9be86db6cde0afa5da0d1d1ac43b42e05dca26</id>
<content type='text'>
</content>
</entry>
<entry>
<title>This AtomicityChecker was introduced a long time ago for reasons</title>
<updated>2020-06-04T23:18:46Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2020-06-04T23:18:46Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=cc6c991ddd53e2f151140cbadef2da660cd7d6a3'/>
<id>urn:sha1:cc6c991ddd53e2f151140cbadef2da660cd7d6a3</id>
<content type='text'>
that are unclear.

This commit removes it because it was causing a bug whereby the
_suspended count on Butler would not go back down to 0 due to signals
being blocked by the AtomicityChecker.

I can see two possibilities:

1. AtomicityChecker is a band-aid for some deeper problem, in which
case other bugs will become apparent.  Perhaps it relates to signals
being sent before the butler/player/playlist are connected to content.

2. AtomicityChecker was correct but was not identifiying signals
from different pieces of content correctly; so the correct fix would
be to add the content pointer to the _checker.send() call and block
based also on that.
</content>
</entry>
<entry>
<title>Naming tweak.</title>
<updated>2020-01-08T20:56:47Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2019-11-19T16:13:25Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=73713b742a2be95ea736d2d3d889f5b535a0f0f1'/>
<id>urn:sha1:73713b742a2be95ea736d2d3d889f5b535a0f0f1</id>
<content type='text'>
</content>
</entry>
<entry>
<title>Clean up access to stuff from Film.</title>
<updated>2020-01-08T20:56:47Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2019-11-19T16:07:35Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=86a866d5f3f5bf2fec67d1c813524479c6727eab'/>
<id>urn:sha1:86a866d5f3f5bf2fec67d1c813524479c6727eab</id>
<content type='text'>
</content>
</entry>
<entry>
<title>Put Time types in dcpomatic namespace.</title>
<updated>2019-05-10T22:43:55Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2019-05-08T22:41:42Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=c4403784febdbdd42e9c32e67fadb147f11fe566'/>
<id>urn:sha1:c4403784febdbdd42e9c32e67fadb147f11fe566</id>
<content type='text'>
</content>
</entry>
<entry>
<title>Fix locking of Playlist to protect against access from the GUI thread</title>
<updated>2019-03-13T10:59:47Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2019-03-13T10:59:47Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=a1a96da90403c0a16a9d9dcde9fd8b66da2daffe'/>
<id>urn:sha1:a1a96da90403c0a16a9d9dcde9fd8b66da2daffe</id>
<content type='text'>
and at the same time traces like

Butler -&gt; Content::end -&gt; Playlist::active_frame_rate_change.
</content>
</entry>
<entry>
<title>swaroop: fix up restart-after-crash.</title>
<updated>2018-12-14T00:58:48Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2018-12-14T00:58:48Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=ed227b4fdba9b4fc7f06f6db4830219f14bad358'/>
<id>urn:sha1:ed227b4fdba9b4fc7f06f6db4830219f14bad358</id>
<content type='text'>
</content>
</entry>
</feed>
