dcpomatic/src/lib/render_text.cc, branch v2.16.35 DCP-o-matic DCP tools https://git.carlh.net/cgit/dcpomatic/atom?h=v2.16.35 2022-12-01T08:21:38Z Escape entities just before Pango rendering (#2382). 2022-12-01T08:21:38Z Carl Hetherington cth@carlh.net 2022-11-30T21:08:00Z urn:sha1:99cb0937e54340fa20c594aaa501276b8321cbf0 Previously, text coming out of the player would have things like & escaped to &. This escaping is also done by libxml++ when writing XML, so doing it in the player would mean it was done twice. We do, however, need to escape things before passing them to Pango as otherwise it gives errors and renders nothing for the line. Here we move the escaping to just before the rendering, meaning that in the reset of DoM we should pass unescaped strings around. Fix subtitle vertical position (#2367). 2022-11-21T19:09:28Z Carl Hetherington cth@carlh.net 2022-11-18T09:56:42Z urn:sha1:323b8cbb0b95297fbd027ffdc4ea5003b59ef25f Previously we would not account for the differences in what vertical position means between Interop and SMPTE. For interop, vertical position is the distance from the reference point to the text baseline, whereas for SMPTE it is the distance from the reference point to the top/middle/bottom of the subtitle (depending on the reference). This caused differences between the preview and the DCP for some cases (notably, using SRT/SSA and making Interop DCPs, or converting Interop DCP subs to SMPTE, or vice versa). Handle vertical alignment of subs correctly wrt the difference between Interop and SMPTE. 2022-07-20T08:22:55Z Carl Hetherington cth@carlh.net 2022-07-06T10:25:15Z urn:sha1:9726a58f44d52d235b027225ddd68c6acf83c733 Whitespace tweak. 2022-07-20T08:22:55Z Carl Hetherington cth@carlh.net 2022-07-06T08:51:30Z urn:sha1:d70f755dde2812bf2311e2ce09563af1b5334d03 Tidy up font rendering for subtitles. 2022-07-20T08:22:55Z Carl Hetherington cth@carlh.net 2022-07-06T08:08:55Z urn:sha1:58c63c02bc26209f42f42bccbe4a587f9df6f05f Here was use get_ink_extents() rather than get_pixel_size() to find out how big the rendered subtitle will be, then use the x/y values of this extents rectangle to offset the rendering within the image. This allows the removal of some hacks to make accents visible. Rearrange subtitle font management. 2022-06-07T15:01:06Z Carl Hetherington cth@carlh.net 2022-06-01T11:03:38Z urn:sha1:5a820bb8fae34591be5ac6d19a73461b9dab532a With this change each subtitle coming out of the player has a reference to a dcpomatic::Font that belongs to the TextContent. This hopefully solves a few problems which all basically stemmed from the fact that previously the decoders/player were deciding what the font ID in the output DCP would be - they can't do that properly. Move fontconfig-related code out to a class. 2022-06-07T15:01:06Z Carl Hetherington cth@carlh.net 2022-06-02T10:52:59Z urn:sha1:9a7b67aee32a40539f29bc2d7017edd4a4f65f11 Improve accuracy of subtitle font sizing. 2022-06-05T21:51:55Z Carl Hetherington cth@carlh.net 2022-06-05T21:51:55Z urn:sha1:f807d3f9751c43bcfa0b260aeb5deca5f00761d2 Use libdcp's warnings.h 2022-04-22T21:27:15Z Carl Hetherington cth@carlh.net 2022-04-22T21:27:15Z urn:sha1:3c29aa6531a4046a8db72dcac81189eb8893233c Fix fade factor calculation when there is no end time. 2021-10-25T08:15:18Z Carl Hetherington cth@carlh.net 2021-10-24T22:40:30Z urn:sha1:500f121343adb67fdbce10a41b1902ccdbbba1e2 In this case we can't do any fade out.