dcpomatic/src/lib/subrip_decoder.h, branch v2.4.13 DCP-o-matic DCP tools https://git.carlh.net/cgit/dcpomatic/atom?h=v2.4.13 2015-10-26T09:37:29Z Reinstate subtitle speed-up patch 526fd6de4c80a7ac9614a1cb0209efff7b171cd5 but only for preview. 2015-10-26T09:37:29Z Carl Hetherington cth@carlh.net 2015-10-26T09:37:29Z urn:sha1:2e62b2c0de47fc8e5bcb5466b2876f9b23d2ae84 Revert "Avoid decoding other packets when looking for subs." 2015-10-23T15:12:14Z Carl Hetherington cth@carlh.net 2015-10-23T15:12:14Z urn:sha1:526fd6de4c80a7ac9614a1cb0209efff7b171cd5 This reverts commit 9e025d3f85f9d6d855b3d5e6c90bca0eac3a3d49. It causes corruption in prophet_clip.xml for reasons that are not yet known. Avoid decoding other packets when looking for subs. 2015-10-16T13:38:44Z Carl Hetherington cth@carlh.net 2015-10-16T13:38:44Z urn:sha1:9e025d3f85f9d6d855b3d5e6c90bca0eac3a3d49 The "accumulation" of, for example, video data when we are looking for audio data is an *optimisation* to reduce the number of seeks. It should not be necessary for correctness (the output should be right even if we never kept anything except what we were looking for). Doing this accumulation is not always an optimisation; sometimes not doing it is better. Avoiding it when going back for subtitles is one of these cases. Fix missing subtitles in some cases. 2015-06-26T21:02:00Z Carl Hetherington cth@carlh.net 2015-06-26T21:02:00Z urn:sha1:c8ff422a42eac30517a7acde57ab84e55449f4e4 We were passing subtitles back from decoders to SubtitleDecoder using dcp::SubtitleStrings and relying on their storage of time to know when the subtitles were. These times are quantised (by the use of dcp::SubtitleString) and then compared with unquantised times (kept as ContentTime) in the main checking loop in SubtitleDecoder::get(). Fix this by storing periods as ContentTimePeriod as well as in the dcp::SubtitleStrings. No-op: remove all trailing whitespace. 2015-06-21T00:15:32Z Carl Hetherington cth@carlh.net 2015-06-21T00:15:32Z urn:sha1:e60bb3e51bd1508b149e6b8f6608f09b5196ae26 Remove PassReason stuff. 2015-06-12T12:47:35Z Carl Hetherington cth@carlh.net 2015-06-12T12:47:35Z urn:sha1:bdbfd6b08856a445446bfd845f1c43109d184250 This feels wrong: it means that it is possible for FFmpegDecoder to discard packets. I can't see how this is ok in all cases: maybe we were lucky that it worked at all. Don't bother decoding video frames when we're seeking around trying to find subtitles. 2015-05-13T09:15:26Z Carl Hetherington cth@carlh.net 2015-05-13T09:15:26Z urn:sha1:9922c1f2eaea674ba2ff6cce5f5853655fd8ad7a Assorted image subtitle fixes. 2015-05-12T15:13:48Z Carl Hetherington cth@carlh.net 2015-05-12T15:13:48Z urn:sha1:2bfd531137f1a4874493186015046e33c5a07c1e Add 'starting' option to subtitles_during(). 2014-07-04T10:43:55Z Carl Hetherington cth@carlh.net 2014-07-04T10:43:55Z urn:sha1:9655db97eae5a6137a45ad809dbf42528dc74408 Hopefully improve subtitle decoder seeking etc. 2014-07-02T17:10:58Z Carl Hetherington cth@carlh.net 2014-07-02T17:10:58Z urn:sha1:c88a8a6ec6b396dc90d40a4843160d616a45db76