dcpomatic/src/lib/update_checker.cc, branch mainDCP-o-matic DCP toolshttps://git.carlh.net/cgit/dcpomatic/atom?h=main2023-03-29T23:25:25ZUse CURLOPT_NOSIGNAL to fix crashes on update check (#2495).2023-03-29T23:25:25ZCarl Hetheringtoncth@carlh.net2023-03-29T23:25:25Zurn:sha1:0fab37d3b61eb150b3de4a4000b8156e6e53574b
Without this, it's possible to come back from curl_easy_perform
in a different thread to the one that it was called from (in the case
of an error).
As I understand it, this happens because a signal handler is called
(from a different thread) and CURLOPT_NOSIGNAL stops this from
happening.
Replace some raw arrays with std::vectors.2022-05-01T22:22:43ZCarl Hetheringtoncth@carlh.net2021-10-11T17:55:06Zurn:sha1:809bcfd85fad2ef7d4131c054be4cccd5bcc9d05Don't abort the update checker thread when one curl_easy_perform fails.2021-07-02T21:37:00ZCarl Hetheringtoncth@carlh.net2021-07-02T21:37:00Zurn:sha1:16e560c3815b52609de103b45c1d5d2cbf155b97Remove unused variable.2021-06-30T23:22:29ZCarl Hetheringtoncth@carlh.net2021-06-30T23:22:29Zurn:sha1:eff6f92fe5d63ba067ef4eac21c2a82e5fb58197Assorted C++11 tidying.2021-02-17T16:33:35ZCarl Hetheringtoncth@carlh.net2021-02-17T16:33:35Zurn:sha1:33e13c4053138930f4b2f59349e441c76111059dFix bugs in thread termination causing occasional pthread2020-07-29T18:22:54ZCarl Hetheringtoncth@carlh.net2020-07-29T18:22:54Zurn:sha1:e3c7656f9dc0acbaf518c051b847ee2e4eb7ba23
assertion failures.
Before this, it was possible for J2KEncoder::terminate_threads()
to finish without terminating all threads if the thread _running_
terminate_threads() was itself interrupt()ed.
This is because the thread_group::join_all() in terminate_threads()
is an interruption point, so it was possible it not to complete
but instead to throw interrupted_exception. Then the owning
J2KEncoder would be torn down but the threads would still be running,
causing use-after-frees.
This commit adds some boost::this_thread::disable_interruption
objects to ensure that the owning thread is not interrupted while
it is being destroyed.
Also tidy up code that does this stuff, assuming that it's safe
to not call thread::joinable but instead do
thread.interrupt();
try {
thread.join();
} catch (...) {}
Various thread cleanups.2020-01-30T21:54:38ZCarl Hetheringtoncth@carlh.net2020-01-30T21:54:38Zurn:sha1:ea6b2dae46caa1da829fbf499e83cd6ae3b3773aFix update check (#1338).2018-07-14T20:54:12ZCarl Hetheringtoncth@carlh.net2018-07-14T20:52:32Zurn:sha1:9f4b7dd032e4d588720d46f858171c7f087f3e23Fix update checket error when there is no test version.2018-03-24T22:46:05ZCarl Hetheringtoncth@carlh.net2018-03-24T22:45:53Zurn:sha1:3d15e81de19a57eb8c6a308e00ea07c542068b58Name threads on Linux.2018-02-16T20:24:37ZCarl Hetheringtoncth@carlh.net2018-02-16T20:24:37Zurn:sha1:8e4a2e5ea578ac4f0f41edb6145d5c0040e33ec2