dcpomatic/src/lib/writer.cc, branch alignmentDCP-o-matic DCP toolshttps://git.carlh.net/cgit/dcpomatic/atom?h=alignment2020-09-23T15:04:53ZBuild fixes.2020-09-23T15:04:53ZCarl Hetheringtoncth@carlh.net2020-09-23T15:04:53Zurn:sha1:6b9f804bf49ceee0ebb9f06be123dccfee2a45abSupport CPL metadata.2020-09-23T09:38:43ZCarl Hetheringtoncth@carlh.net2020-09-04T15:24:12Zurn:sha1:d97029163865e212dc3d7b3c57c16459933a11f6Adapt for changes to libdcp API.2020-09-23T09:38:43ZCarl Hetheringtoncth@carlh.net2020-09-04T07:29:41Zurn:sha1:7ab22a7aa171aec36563b8ec0b7c0b69a36094feFix bugs in thread termination causing occasional pthread2020-07-29T18:22:54ZCarl Hetheringtoncth@carlh.net2020-07-29T18:22:54Zurn:sha1:e3c7656f9dc0acbaf518c051b847ee2e4eb7ba23
assertion failures.
Before this, it was possible for J2KEncoder::terminate_threads()
to finish without terminating all threads if the thread _running_
terminate_threads() was itself interrupt()ed.
This is because the thread_group::join_all() in terminate_threads()
is an interruption point, so it was possible it not to complete
but instead to throw interrupted_exception. Then the owning
J2KEncoder would be torn down but the threads would still be running,
causing use-after-frees.
This commit adds some boost::this_thread::disable_interruption
objects to ensure that the owning thread is not interrupted while
it is being destroyed.
Also tidy up code that does this stuff, assuming that it's safe
to not call thread::joinable but instead do
thread.interrupt();
try {
thread.join();
} catch (...) {}
Make Atmos content work more like other content. Now its MXFs2020-06-19T13:07:30ZCarl Hetheringtoncth@carlh.net2020-06-19T11:30:02Zurn:sha1:ca981c8cfa23111e92be329f1c2dfbe3a07b4247
are re-written, meaning that they can be encrypted.
This (along with the libdcp update) also fixes assorted Atmos bugs.
Always sign DCPs (#1760).2020-06-08T15:09:15ZCarl Hetheringtoncth@carlh.net2020-06-08T00:11:18Zurn:sha1:8755ef75cb001cf7fba230ffa98fb40eb2547849Difficult to see how any unprotected write with multiple readers2020-05-20T19:56:28ZCarl Hetheringtoncth@carlh.net2020-05-19T23:51:25Zurn:sha1:93f6b7f36dba0eed49936dcd014a9cf5941a66ac
could be safe.
Add _last_written to Writer, containing the last written frame and eyes2020-04-18T22:57:23ZCarl Hetheringtoncth@carlh.net2020-04-18T18:42:58Zurn:sha1:6e003ef110717dd3e4ecdb009d33671f7834e024
to each reel. This is updated when things are popped off the queue, with
_state_mutex_held, and used in preference to the ones in ReelWriter
which were previously being updated during the time the _state_mutex
lock is unlocked in the body of Writer::thread(). This was not
thread safe (thanks, valgrind!)
Use a BOOST_FOREACH.2020-04-18T22:57:23ZCarl Hetheringtoncth@carlh.net2020-04-17T20:00:06Zurn:sha1:be4082c68004d56ad7f14b7b9cddef640118dd62Rename a variable.2020-04-18T22:57:23ZCarl Hetheringtoncth@carlh.net2020-04-17T19:59:14Zurn:sha1:143cfcf6c9e8c0a0879652d0d741ec268e8d9541