dcpomatic/src/lib/writer.cc, branch arbitrary-hzDCP-o-matic DCP toolshttps://git.carlh.net/cgit/dcpomatic/atom?h=arbitrary-hz2025-09-02T20:40:13ZUntested conversion to num/den DCPTime.2025-09-02T20:40:13ZCarl Hetheringtoncth@carlh.net2024-12-21T23:09:57Zurn:sha1:33b0928b20618da5bc295711bfdf3d638863afa5
Summary of required changes:
Replace ::from_frames with a constructor that takes num/den.
Provide and use member to_debug_string() instead of to_string().
Provide and use member to_serializable_string() and string constructor instead of fmt::to_string on .get() and number constructor.
Provide and use content_time() member instead of ContentTime constructor from DCPTime.
Use frames_round(96000) instead of get() when comparing times to see if they are "close enough".
Provide and use DCPTime(x, FrameRateChange) constructor when converting from ContentTime.
Use .seconds() when calculating proportions or sometimes when dividing by HZ.
Provide and use operator bool().
Pass explicit 96000 denominator in a lot of places.
Add member max() and use it instead of static max()
Change BOOST_CHECK_EQUAL to BOOST_CHECK
Provide operator/ and use it instead of .get() / 2.
Move write_cover_sheet() out to its own file.2025-08-25T06:47:42ZCarl Hetheringtoncth@carlh.net2025-08-22T19:50:00Zurn:sha1:99a191c599724ee8bab43146f9ea5da388c10225White space: writer.{cc,h}2025-08-22T19:35:44ZCarl Hetheringtoncth@carlh.net2025-08-22T19:35:44Zurn:sha1:61c74126cde9592587d31b4acbc54dd6c76a44d3Remove compose.hpp includes.2025-07-10T18:50:32ZCarl Hetheringtoncth@carlh.net2025-07-09T20:58:37Zurn:sha1:bad01065584014aee4024e7cbc4a66acac7617e1
sed -i "/include.*compose.hpp/d;" src/lib/*.cc src/wx/*.cc src/wx/*.h src/tools/*.cc src/lib/*.h test/*.cc
Replace String::compose with fmt.2025-07-10T18:50:32ZCarl Hetheringtoncth@carlh.net2025-07-09T20:53:27Zurn:sha1:62c34b28567a097e8f22576e7d7891bd3dbe0ac0
sed -i "/Plural-Forms/n;/%100/n;/scanf/n;s/%[123456789]/{}/g" src/lib/*.cc src/lib/*.h src/wx/*.cc src/tools/*.cc src/lib/po/*.po src/wx/po/*.po src/tools/po/*.po test/*.cc
sed -i "s/String::compose */fmt::format/g" src/lib/*.cc src/lib/*.h src/wx/*.cc src/tools/*.cc test/*.cc
Pass Ratio around as an object rather than a pointer.2025-06-16T22:04:03ZCarl Hetheringtoncth@carlh.net2025-05-31T23:39:04Zurn:sha1:ec06811bae7ed4fc6bd80c3154fd473028ee8e13Fix case where -ve duration subtitles could be created at reel boundaries (#3012)2025-04-12T20:25:04ZCarl Hetheringtoncth@carlh.net2025-04-12T20:25:04Zurn:sha1:19f1a934c9e3531da3bd95cdc854f491ee14e215Bump libdcp for Bv2.0 fixes (#2988).2025-03-27T00:43:05ZCarl Hetheringtoncth@carlh.net2025-03-27T00:43:05Zurn:sha1:059f68ed9d6d74fc6dd28e034db8a4f743c7a76cFix crash due to crosss-thread list access.2025-03-22T12:29:59ZCarl Hetheringtoncth@carlh.net2025-03-21T12:37:34Zurn:sha1:e93b66f4236ec25dbd0603bbe74c904b53180e91
I've seen it happen that item points to a different QueueItem after the
lock was unlocked here, which I didn't think was possible. Backtraces
suggest that when problems happen _queue is being sorted in another
thread, and perhaps this is not allowed (I couldn't find any conclusive
proof in any documentation).
There is also a potential problem with the newly-added zombify() method,
which takes the lock and clears the list.
Use make_shared.2025-03-22T12:29:59ZCarl Hetheringtoncth@carlh.net2025-03-21T12:34:41Zurn:sha1:3f1cffe8a0afe23577fe7351c05f1aa1dc492032