dcpomatic/test/audio_analysis_test.cc, branch arbitrary-hzDCP-o-matic DCP toolshttps://git.carlh.net/cgit/dcpomatic/atom?h=arbitrary-hz2025-09-02T20:40:13ZUntested conversion to num/den DCPTime.2025-09-02T20:40:13ZCarl Hetheringtoncth@carlh.net2024-12-21T23:09:57Zurn:sha1:33b0928b20618da5bc295711bfdf3d638863afa5
Summary of required changes:
Replace ::from_frames with a constructor that takes num/den.
Provide and use member to_debug_string() instead of to_string().
Provide and use member to_serializable_string() and string constructor instead of fmt::to_string on .get() and number constructor.
Provide and use content_time() member instead of ContentTime constructor from DCPTime.
Use frames_round(96000) instead of get() when comparing times to see if they are "close enough".
Provide and use DCPTime(x, FrameRateChange) constructor when converting from ContentTime.
Use .seconds() when calculating proportions or sometimes when dividing by HZ.
Provide and use operator bool().
Pass explicit 96000 denominator in a lot of places.
Add member max() and use it instead of static max()
Change BOOST_CHECK_EQUAL to BOOST_CHECK
Provide operator/ and use it instead of .get() / 2.
Change Film::examine_and_add_content to take a vector of content.2025-07-15T16:03:57ZCarl Hetheringtoncth@carlh.net2025-07-15T01:36:59Zurn:sha1:21415bdb69a99c4fc36cf4b5e5160a171bb1cad4Add ebur128 test.2024-07-03T21:47:11ZCarl Hetheringtoncth@carlh.net2024-07-03T21:47:11Zurn:sha1:5696315078be7a3f61763690ddc201c558ddcd5aRename new_test_film2 -> new_test_film.2024-05-22T08:33:45ZCarl Hetheringtoncth@carlh.net2024-05-20T14:55:57Zurn:sha1:c95ba3eb99c5e4d6dca90cee7e5bb9077b6ed02cReplace all new_test_film with new_test_film2.2024-05-21T21:52:46ZCarl Hetheringtoncth@carlh.net2024-05-20T14:54:37Zurn:sha1:e3dba6242aed7415eddbbfb1e5d56ce6680603c1Fix apparently ineffective processors when analysing audio (#2671).2024-02-11T21:55:27ZCarl Hetheringtoncth@carlh.net2024-02-11T12:10:48Zurn:sha1:527093fa643049d370f4daee8206349981edbf95
A whole film ("DCP side") analysis would behave the same as a
single piece of content analysis if the film only had one piece
of content.
Here we also clarify that audio analysis of the whole film is different
to that for a single piece of content; for the whole film we use processors,
and for single pieces of content we do not.
Fix audio analysis attempts with source files that have more channels than the film.2023-11-20T06:34:23ZCarl Hetheringtoncth@carlh.net2023-11-15T16:02:16Zurn:sha1:5b916bf26e3ad1cc49ef8e498bd5e4ff844ed7dbDon't feed channels to leqm that we don't have a correction factor for (#2647).2023-11-20T06:34:23ZCarl Hetheringtoncth@carlh.net2023-11-07T23:18:22Zurn:sha1:4ae0193c125cc70176eb1660919d507fbf5378e4Cleanup: use a lambda.2023-09-30T20:58:45ZCarl Hetheringtoncth@carlh.net2023-09-30T20:58:45Zurn:sha1:6ef4d958bb329ae190fd0b99114cf29bbd842393Remove now-unnecessary assertion.2023-08-15T13:02:54ZCarl Hetheringtoncth@carlh.net2023-08-15T13:02:29Zurn:sha1:f6c6232941671095b0a857a5a5c5392f52d6c3aa
Since e29ce33a36c2e20444d57196defc86d5072bce81 channels is the
number of channels in the frame, and also the number in data,
so we don't need to check this any more.