dcpomatic/test/content_test.cc, branch arbitrary-hzDCP-o-matic DCP toolshttps://git.carlh.net/cgit/dcpomatic/atom?h=arbitrary-hz2025-09-02T20:40:13ZUntested conversion to num/den DCPTime.2025-09-02T20:40:13ZCarl Hetheringtoncth@carlh.net2024-12-21T23:09:57Zurn:sha1:33b0928b20618da5bc295711bfdf3d638863afa5
Summary of required changes:
Replace ::from_frames with a constructor that takes num/den.
Provide and use member to_debug_string() instead of to_string().
Provide and use member to_serializable_string() and string constructor instead of fmt::to_string on .get() and number constructor.
Provide and use content_time() member instead of ContentTime constructor from DCPTime.
Use frames_round(96000) instead of get() when comparing times to see if they are "close enough".
Provide and use DCPTime(x, FrameRateChange) constructor when converting from ContentTime.
Use .seconds() when calculating proportions or sometimes when dividing by HZ.
Provide and use operator bool().
Pass explicit 96000 denominator in a lot of places.
Add member max() and use it instead of static max()
Change BOOST_CHECK_EQUAL to BOOST_CHECK
Provide operator/ and use it instead of .get() / 2.
Change Film::examine_and_add_content to take a vector of content.2025-07-15T16:03:57ZCarl Hetheringtoncth@carlh.net2025-07-15T01:36:59Zurn:sha1:21415bdb69a99c4fc36cf4b5e5160a171bb1cad4Remove default video bit rate settings.2024-05-29T08:35:55ZCarl Hetheringtoncth@carlh.net2024-05-09T20:13:15Zurn:sha1:2d82f86d2f99b812edd5d64d13f3dd5a4950719eRename new_test_film2 -> new_test_film.2024-05-22T08:33:45ZCarl Hetheringtoncth@carlh.net2024-05-20T14:55:57Zurn:sha1:c95ba3eb99c5e4d6dca90cee7e5bb9077b6ed02cClean up some more tests.2024-05-20T15:05:16ZCarl Hetheringtoncth@carlh.net2024-05-20T15:05:16Zurn:sha1:2d5c461cbc1ebef67d0afdcb1dd2272dad58c22bClean up another big test.2024-05-20T14:58:55ZCarl Hetheringtoncth@carlh.net2024-05-20T14:58:55Zurn:sha1:8366fcb9b393563a44255a445b5784e468016077Use new_test_film2.2024-05-20T14:00:47ZCarl Hetheringtoncth@carlh.net2024-05-20T14:00:47Zurn:sha1:df6cc62c6acb30d42581e07c2eefdcea0e25110dChange how video timing is done.2024-01-28T01:01:56ZCarl Hetheringtoncth@carlh.net2022-09-29T08:17:50Zurn:sha1:895143459866dcb373c93b8e674d1344a129a6df
This commit changes the approach with video timing. Previously,
we would (more-or-less) try to use every video frame from the content
in the output, hoping that they come at a constant frame rate.
This is not always the case, however. Here we preserve the PTS
of video frames, and then when one arrives we output whatever
DCP video frames we can (at the regular DCP frame rate).
Hopefully this will solve a range of sync problems, but it
could also introduce new ones.
Fix errors with WAVs containing markers (#2617).2023-09-28T22:57:58ZCarl Hetheringtoncth@carlh.net2023-09-26T22:16:38Zurn:sha1:e67ce8ae4b9121bbcef2c1dcb61bdb5b9330ad78
I'm not 100% sure about this but they seem to end up giving audio
packets with no channels and no frames. Here we handle such packets
better.
Go back to respecting the user's choice for the number of audio channels in the MXF.2023-08-06T20:05:03ZCarl Hetheringtoncth@carlh.net2023-07-25T09:04:30Zurn:sha1:02d4493e593d567b210cd7f2b98d33a345867d1d