<feed xmlns='http://www.w3.org/2005/Atom'>
<title>dcpomatic/test/dcp_subtitle_test.cc, branch arbitrary-hz</title>
<subtitle>DCP-o-matic DCP tools</subtitle>
<id>https://git.carlh.net/cgit/dcpomatic/atom?h=arbitrary-hz</id>
<link rel='self' href='https://git.carlh.net/cgit/dcpomatic/atom?h=arbitrary-hz'/>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/'/>
<updated>2025-09-02T20:40:13Z</updated>
<entry>
<title>Untested conversion to num/den DCPTime.</title>
<updated>2025-09-02T20:40:13Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2024-12-21T23:09:57Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=33b0928b20618da5bc295711bfdf3d638863afa5'/>
<id>urn:sha1:33b0928b20618da5bc295711bfdf3d638863afa5</id>
<content type='text'>
Summary of required changes:

Replace ::from_frames with a constructor that takes num/den.
Provide and use member to_debug_string() instead of to_string().
Provide and use member to_serializable_string() and string constructor instead of fmt::to_string on .get() and number constructor.
Provide and use content_time() member instead of ContentTime constructor from DCPTime.
Use frames_round(96000) instead of get() when comparing times to see if they are "close enough".
Provide and use DCPTime(x, FrameRateChange) constructor when converting from ContentTime.
Use .seconds() when calculating proportions or sometimes when dividing by HZ.
Provide and use operator bool().
Pass explicit 96000 denominator in a lot of places.
Add member max() and use it instead of static max()
Change BOOST_CHECK_EQUAL to BOOST_CHECK
Provide operator/ and use it instead of .get() / 2.
</content>
</entry>
<entry>
<title>Bump libdcp for very invalid subtitle duration checks.</title>
<updated>2025-04-14T16:42:09Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2025-04-12T20:42:32Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=ec02427b46e95fa2a63ad680e0a9787f2d306305'/>
<id>urn:sha1:ec02427b46e95fa2a63ad680e0a9787f2d306305</id>
<content type='text'>
</content>
</entry>
<entry>
<title>Fix subtitles being written with negative times when trimmed (#2965).</title>
<updated>2025-02-03T00:32:02Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2025-02-01T14:59:20Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=a5e1a485a825a0967142fae98488fc79e345cb4a'/>
<id>urn:sha1:a5e1a485a825a0967142fae98488fc79e345cb4a</id>
<content type='text'>
</content>
</entry>
<entry>
<title>Adapt to some libdcp class renaming to allow open captions/closed subtitles.</title>
<updated>2024-09-03T15:02:24Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2024-08-06T21:57:22Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=f3ab77e34a41ad4d8f5156e9d6598314975b9565'/>
<id>urn:sha1:f3ab77e34a41ad4d8f5156e9d6598314975b9565</id>
<content type='text'>
</content>
</entry>
<entry>
<title>Simplify the FontIDAllocator a lot (#2827).</title>
<updated>2024-06-11T07:52:28Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2024-06-09T23:05:43Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=a224ef26f48e1a9a9189c2b935abb06147b342bc'/>
<id>urn:sha1:a224ef26f48e1a9a9189c2b935abb06147b342bc</id>
<content type='text'>
This is at the expense of forward compatibility, and the need to
re-examine subtitle content (losing custom fonts as we do so).

But it does mean that the code is simpler, and there's not this weird
growth of IDs where a DCP gets imported with some font, and then the ID
becomes 0_font, and if you do it again it's 0_0_font, and so on.
</content>
</entry>
<entry>
<title>Rename new_test_film2 -&gt; new_test_film.</title>
<updated>2024-05-22T08:33:45Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2024-05-20T14:55:57Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=c95ba3eb99c5e4d6dca90cee7e5bb9077b6ed02c'/>
<id>urn:sha1:c95ba3eb99c5e4d6dca90cee7e5bb9077b6ed02c</id>
<content type='text'>
</content>
</entry>
<entry>
<title>Replace all new_test_film with new_test_film2.</title>
<updated>2024-05-21T21:52:46Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2024-05-20T14:54:37Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=e3dba6242aed7415eddbbfb1e5d56ce6680603c1'/>
<id>urn:sha1:e3dba6242aed7415eddbbfb1e5d56ce6680603c1</id>
<content type='text'>
</content>
</entry>
<entry>
<title>Rename classes to follow preparatory renames in libdcp.</title>
<updated>2024-04-21T21:17:17Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2023-11-29T23:29:16Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=d3b5b533ebba1a1534eb37cc41032876a48a3d82'/>
<id>urn:sha1:d3b5b533ebba1a1534eb37cc41032876a48a3d82</id>
<content type='text'>
</content>
</entry>
<entry>
<title>Inspect most DCPs made during tests with ClairMeta (#76).</title>
<updated>2024-01-15T11:44:53Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2024-01-12T14:29:12Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=de1b4a967e6854782e88e83d48af74289977c8c3'/>
<id>urn:sha1:de1b4a967e6854782e88e83d48af74289977c8c3</id>
<content type='text'>
</content>
</entry>
<entry>
<title>Fix handling of empty font IDs and default DCP fonts (#2721) (part of #2722).</title>
<updated>2024-01-15T09:21:59Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2024-01-13T22:34:35Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=db22f81ccce9e1a5f205e6d8b3c0631fc039a173'/>
<id>urn:sha1:db22f81ccce9e1a5f205e6d8b3c0631fc039a173</id>
<content type='text'>
Previously we used an empty font ID as the default for when a subtitle
has no Font, but in #2721 we saw a DCP with an empty font ID which
raised an assertion (because we'd already added our default font with
the empty ID).

Here we try to fix this (and also make the default font correctly be
that from the first &lt;LoadFont&gt;).
</content>
</entry>
</feed>
