dcpomatic/test/isdcf_name_test.cc, branch split DCP-o-matic DCP tools https://git.carlh.net/cgit/dcpomatic/atom?h=split 2023-09-12T21:14:35Z Somewhat fix inclusion of CCAP language in ISDCF name (#2610). 2023-09-12T21:14:35Z Carl Hetherington cth@carlh.net 2023-09-12T21:14:35Z urn:sha1:9c4e649a755918a6f41cf8c16647cc8af58f8376 Fix some typos in comments. 2023-05-13T06:54:58Z Carl Hetherington cth@carlh.net 2023-04-11T21:03:36Z urn:sha1:87c1ac59d40f611fed94fa4120f9c21ef2baa2d2 Use IAB rather than ATMOS in ISDCF names (#2482). 2023-03-11T00:31:03Z Carl Hetherington cth@carlh.net 2023-03-11T00:31:03Z urn:sha1:dacf46c8aa5b399a7d51c9d0808869af9b73791c Fix isdcf name ATMOS test. 2023-01-22T23:26:38Z Carl Hetherington cth@carlh.net 2023-01-22T23:26:38Z urn:sha1:cc279961a2a9ffea67ed21378fef44c2e1bcb202 Add -ISDCF to ISDCF name as required (#2416). 2023-01-17T23:53:17Z Carl Hetherington cth@carlh.net 2023-01-17T23:53:17Z urn:sha1:7c0e02d933c243f0559631402e02fb598caf4647 Don't use "NR" in the ISDCF name if there is no rating. 2022-12-02T20:52:38Z Carl Hetherington cth@carlh.net 2022-12-02T20:52:38Z urn:sha1:d5e6fa029f1fb7b7dccd32dd2906a0858a876cae Thierry says this is not used out in the wild, and I can't find any reference to say that it must be there, so remove it. Remove - and + from ratings before using them in a DCNC name. 2022-09-03T20:52:21Z Carl Hetherington cth@carlh.net 2022-09-03T20:52:19Z urn:sha1:259dd8a083b987d2d154b12859cd90f7c8dcb607 I can't find any documentation about what we should do here, but at least this rule fits what https://registry-page.isdcf.com/ratings/ does. Use a vector rather than a list when returning from content_factory(). 2022-07-11T10:22:11Z Carl Hetherington cth@carlh.net 2022-07-09T18:41:10Z urn:sha1:b1e22dff981fb86ae04b12bb5a064e61030793a8 Lookup the correct DCNC code to use for languages rather than just 2022-04-20T20:31:08Z Carl Hetherington cth@carlh.net 2022-04-17T20:25:50Z urn:sha1:e6d7b6d8520c7454ecf67df7269056a16d0e2b70 using the language's subtag (#2235). Put audio language back in the Film. 2021-06-01T12:25:17Z Carl Hetherington cth@carlh.net 2021-06-01T09:28:48Z urn:sha1:ddd767fd647b2fd585d75ada000d3d01c4c43cb2 It feels neat to have audio language in the audio tab, to match the subtitle language in the subtitle tab. It also avoids the potential confusion of there being an audio language setting in the DCP metadata but no subtitle language setting. However: - I am yet to find a need to describe multiple audio languages in the same DCP (all previous users of Film::audio_languages() were just taking the first language off the list). - As Carsten points out it's fiddly to have to set the audio language for 5 separate-channel WAV files, for example (you wouldn't actually have had to do this, but it would have felt like you did). I think subtitle language remains neater where it is (per-content) as there is this additional subtitle language metadata and it makes much more sense (and is much more likely) that there are multiple subtitle languages in a DCP than it does multiple audio languages.