dcpomatic/test/reel_writer_test.cc, branch arbitrary-hzDCP-o-matic DCP toolshttps://git.carlh.net/cgit/dcpomatic/atom?h=arbitrary-hz2025-09-02T20:40:13ZUntested conversion to num/den DCPTime.2025-09-02T20:40:13ZCarl Hetheringtoncth@carlh.net2024-12-21T23:09:57Zurn:sha1:33b0928b20618da5bc295711bfdf3d638863afa5
Summary of required changes:
Replace ::from_frames with a constructor that takes num/den.
Provide and use member to_debug_string() instead of to_string().
Provide and use member to_serializable_string() and string constructor instead of fmt::to_string on .get() and number constructor.
Provide and use content_time() member instead of ContentTime constructor from DCPTime.
Use frames_round(96000) instead of get() when comparing times to see if they are "close enough".
Provide and use DCPTime(x, FrameRateChange) constructor when converting from ContentTime.
Use .seconds() when calculating proportions or sometimes when dividing by HZ.
Provide and use operator bool().
Pass explicit 96000 denominator in a lot of places.
Add member max() and use it instead of static max()
Change BOOST_CHECK_EQUAL to BOOST_CHECK
Provide operator/ and use it instead of .get() / 2.
Give ownership of info files to ReelWriters (#2912).2024-12-26T16:20:25ZCarl Hetheringtoncth@carlh.net2024-12-16T00:58:57Zurn:sha1:24728b74693bb84d79474e014cdb952abc8a79f2
The motivation here is to stop a pattern where we create a file, close
it, and then re-open it (many times) as I think there are problems on
Windows when a virus scanner sees the new file, opens it for checking,
and then we can't re-open it.
This also makes things a fair bit simpler, as a lock is removed and we
don't try to differentiate read/write cases by opening the file in
different ways; it's now always writeable.
Rename new_test_film2 -> new_test_film.2024-05-22T08:33:45ZCarl Hetheringtoncth@carlh.net2024-05-20T14:55:57Zurn:sha1:c95ba3eb99c5e4d6dca90cee7e5bb9077b6ed02cStop using video directory and hard-linking (#2756).2024-05-11T19:00:37ZCarl Hetheringtoncth@carlh.net2024-03-14T23:41:20Zurn:sha1:d2c665cba983c625933817e0bf05e298f80f0119
Instead store details of a previously-created asset in the film's
metadata and then look there for potential video files to re-use.
Extract frame info read/write to new class.2024-04-21T21:18:23ZCarl Hetheringtoncth@carlh.net2024-03-26T21:43:10Zurn:sha1:f7518583f90a866a07d8069a78bebcea82b2b248Inspect most DCPs made during tests with ClairMeta (#76).2024-01-15T11:44:53ZCarl Hetheringtoncth@carlh.net2024-01-12T14:29:12Zurn:sha1:de1b4a967e6854782e88e83d48af74289977c8c3Use a vector rather than a list when returning from content_factory().2022-07-11T10:22:11ZCarl Hetheringtoncth@carlh.net2022-07-09T18:41:10Zurn:sha1:b1e22dff981fb86ae04b12bb5a064e61030793a8C++11 tidying.2021-05-03T18:18:04ZCarl Hetheringtoncth@carlh.net2021-05-03T09:17:34Zurn:sha1:689fa55d1529ad88449ca464e9107c4dcc54d1cbVerify a whole bunch of DCPs made by unit tests.2021-02-23T19:09:39ZCarl Hetheringtoncth@carlh.net2021-02-21T19:28:59Zurn:sha1:41262015eb2bb1fc3da8585883420975de381a65More enum class additions.2021-01-31T02:14:24ZCarl Hetheringtoncth@carlh.net2021-01-31T02:14:24Zurn:sha1:8fedaaa75c4586a4cc7ffb393bd71d1fdb091dc8