<feed xmlns='http://www.w3.org/2005/Atom'>
<title>dcpomatic/test, branch debug-corruption</title>
<subtitle>DCP-o-matic DCP tools</subtitle>
<id>https://git.carlh.net/cgit/dcpomatic/atom?h=debug-corruption</id>
<link rel='self' href='https://git.carlh.net/cgit/dcpomatic/atom?h=debug-corruption'/>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/'/>
<updated>2024-09-12T23:14:21Z</updated>
<entry>
<title>Hopefully fix occasional hang in j2k_encoder_deadlock_test.</title>
<updated>2024-09-12T23:14:21Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2024-09-12T22:56:17Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=f02501491e262c52b65c3fea6e180814e132dad8'/>
<id>urn:sha1:f02501491e262c52b65c3fea6e180814e132dad8</id>
<content type='text'>
Previously too many frames were queued for encoding, which AFAICS meant
that (if the CPU was busy) we would get to the point where too many frames
were in the encoder queue, so that we blocked waiting for it to clear,
and then simultaneously too many frames were in the writer queue, which
(in this test) would never clear.

At this point we would be backed up waiting for Writer::write() to happen
in J2KEncoder::encoder_thread() so that the encoder queue could be cleared,
but nobody is calling Writer::write().
</content>
</entry>
<entry>
<title>Bump sleep a little to try and de-flake a test.</title>
<updated>2024-09-12T20:49:48Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2024-09-12T20:49:48Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=518dc747e2437d0a51ff4582e79f47ea1754f057'/>
<id>urn:sha1:518dc747e2437d0a51ff4582e79f47ea1754f057</id>
<content type='text'>
</content>
</entry>
<entry>
<title>Fix error when importing bad subtitle file (#2838).</title>
<updated>2024-06-27T18:14:31Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2024-06-27T18:14:31Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=d6e8b54b2b60f70f1a8837183bc184809977be67'/>
<id>urn:sha1:d6e8b54b2b60f70f1a8837183bc184809977be67</id>
<content type='text'>
The subtitle XML refers to a font with no corresponding &lt;LoadFont&gt;.
</content>
</entry>
<entry>
<title>Fix font ID allocation from DCP when there are subs and ccaps using the same IDs (#2822).</title>
<updated>2024-06-07T19:09:03Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2024-06-07T19:09:03Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=2d89772ba5b5bc3b2e010b3bbbafe2efa9300353'/>
<id>urn:sha1:2d89772ba5b5bc3b2e010b3bbbafe2efa9300353</id>
<content type='text'>
Previously we would always use &lt;last-reel+1&gt;_id as a disambiguated ID
for every case.
</content>
</entry>
<entry>
<title>Fix stream length for DCP content (#2688).</title>
<updated>2024-05-21T07:38:03Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2024-05-20T13:21:51Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=eeef6e5e41163257145e5e6d4418c28b6970bae2'/>
<id>urn:sha1:eeef6e5e41163257145e5e6d4418c28b6970bae2</id>
<content type='text'>
</content>
</entry>
<entry>
<title>Make sure we don't say some content has audio if none will be emitted.</title>
<updated>2024-05-17T13:02:57Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2024-05-17T13:02:57Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=afd18ea6b14373b2078b6d6dbc74c836e6843757'/>
<id>urn:sha1:afd18ea6b14373b2078b6d6dbc74c836e6843757</id>
<content type='text'>
In the FFmpeg (and shortly DCP) case we don't emit any audio if none is mapped,
so we must take this into account in the player.
</content>
</entry>
<entry>
<title>Work around deadlock when destroying J2KEncoder with a full writer queue (#2784).</title>
<updated>2024-05-07T23:33:41Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2024-05-05T19:34:29Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=32d04ddb5c583938f470ed74bda8a50cc2ec9960'/>
<id>urn:sha1:32d04ddb5c583938f470ed74bda8a50cc2ec9960</id>
<content type='text'>
This feels like a hack, but I can't think of a nicer way to do it.

The interruption disable makes sense because when we destroy encoder threads
during a DCP encode (because a remote server goes away, for example) we don't
want any frames to be lost due to the encode thread being interrupted between
taking the frame off the queue and sending it to the writer.

When we're destroying the encoder we don't care about this, but I can't see
how you'd differentiate.

Maybe the encoder queue could have two lists: to-do and in-progress;
the encoder thread atomically moves a frame from to-do to in-progress,
but then how do you know when the in-progress ones are orphaned and need
to be re-added to the main queue.

You could make the writer return saying "no" if the queue is full (rather
than blocking and waiting for the queue to empty) but that seems wasteful
as then the frame would be re-encoded.
</content>
</entry>
<entry>
<title>Fix hanging/overlapping dvb subtitles (#2792).</title>
<updated>2024-03-31T23:04:43Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2024-03-31T23:04:41Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=94618a724124cbf5fe9f0b47a3fdce601fcd5581'/>
<id>urn:sha1:94618a724124cbf5fe9f0b47a3fdce601fcd5581</id>
<content type='text'>
This reverts a change made in
8ca6fd6d97e6d42492afddb655fa85130946853c
"Fix doubled subtitles if subtitle stop times are specified."

That change breaks the case where a subtitle _does_ have a stop time,
but it's wrong (30s from the start time) and we want the next subtitle
to clear the previous one.

I can't now see how reverting this could cause doubled subtitles,
so maybe that problem wlil come back.  At least now there's a test
for #2792.
</content>
</entry>
<entry>
<title>Fix failing tests.</title>
<updated>2024-03-20T06:41:24Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2024-03-11T14:25:16Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=026f7e95210cafb6b44a1c207041df085ce92d95'/>
<id>urn:sha1:026f7e95210cafb6b44a1c207041df085ce92d95</id>
<content type='text'>
Broken in the fix for #2780, when we started to check that referenced
audio MXFs have the correct number of channels.
</content>
</entry>
<entry>
<title>Fix screen name order in KDM emails.</title>
<updated>2024-03-07T22:33:03Z</updated>
<author>
<name>Carl Hetherington</name>
<email>cth@carlh.net</email>
</author>
<published>2024-03-07T22:33:03Z</published>
<link rel='alternate' type='text/html' href='https://git.carlh.net/cgit/dcpomatic/commit/?id=04b5957318df591f56e0a5d39720df143dc8230d'/>
<id>urn:sha1:04b5957318df591f56e0a5d39720df143dc8230d</id>
<content type='text'>
</content>
</entry>
</feed>
