diff options
| author | Carl Hetherington <cth@carlh.net> | 2020-03-09 21:35:48 +0100 |
|---|---|---|
| committer | Carl Hetherington <cth@carlh.net> | 2020-03-11 22:24:28 +0100 |
| commit | ec06bc09c3ee7e69fb99056d8b665b733021e6a7 (patch) | |
| tree | cb87de6a766488b65bfc4a4a00f7c3bf1b227ff8 | |
| parent | 1befa3d286a5016e897f1a23cc60cd3d3b96e63a (diff) | |
Get some better errors when verification-based tests fail.
| -rw-r--r-- | test/reels_test.cc | 25 |
1 files changed, 20 insertions, 5 deletions
diff --git a/test/reels_test.cc b/test/reels_test.cc index c6fb21977..7bf48a9cb 100644 --- a/test/reels_test.cc +++ b/test/reels_test.cc @@ -492,6 +492,14 @@ no_op () } +static void +dump_notes (list<dcp::VerificationNote> const & notes) +{ + BOOST_FOREACH (dcp::VerificationNote i, notes) { + std::cout << dcp::note_to_string(i) << "\n"; + } +} + /** Using less than 1 second's worth of content should not result in a reel * of less than 1 second's duration. @@ -511,7 +519,9 @@ BOOST_AUTO_TEST_CASE (reels_should_not_be_short1) vector<boost::filesystem::path> dirs; dirs.push_back (film->dir(film->dcp_name(false))); - BOOST_REQUIRE (dcp::verify(dirs, boost::bind(&no_op), boost::bind(&no_op), TestPaths::xsd).empty()); + list<dcp::VerificationNote> const notes = dcp::verify(dirs, boost::bind(&no_op), boost::bind(&no_op), TestPaths::xsd); + dump_notes (notes); + BOOST_REQUIRE (notes.empty()); } /** Leaving less than 1 second's gap between two pieces of content with @@ -539,7 +549,9 @@ BOOST_AUTO_TEST_CASE (reels_should_not_be_short2) vector<boost::filesystem::path> dirs; dirs.push_back (film->dir(film->dcp_name(false))); - BOOST_REQUIRE (dcp::verify(dirs, boost::bind(&no_op), boost::bind(&no_op), TestPaths::xsd).empty()); + list<dcp::VerificationNote> const notes = dcp::verify(dirs, boost::bind(&no_op), boost::bind(&no_op), TestPaths::xsd); + dump_notes (notes); + BOOST_REQUIRE (notes.empty()); } /** Setting REELTYPE_BY_LENGTH and using a small length value should not make @@ -561,8 +573,9 @@ BOOST_AUTO_TEST_CASE (reels_should_not_be_short3) BOOST_REQUIRE (!wait_for_jobs()); vector<boost::filesystem::path> dirs; - dirs.push_back (film->dir(film->dcp_name(false))); - BOOST_REQUIRE (dcp::verify(dirs, boost::bind(&no_op), boost::bind(&no_op), TestPaths::xsd).empty()); + list<dcp::VerificationNote> const notes = dcp::verify(dirs, boost::bind(&no_op), boost::bind(&no_op), TestPaths::xsd); + dump_notes (notes); + BOOST_REQUIRE (notes.empty()); } /** Having one piece of content less than 1s long in REELTYPE_BY_VIDEO_CONTENT @@ -590,6 +603,8 @@ BOOST_AUTO_TEST_CASE (reels_should_not_be_short4) vector<boost::filesystem::path> dirs; dirs.push_back (film->dir(film->dcp_name(false))); - BOOST_REQUIRE (dcp::verify(dirs, boost::bind(&no_op), boost::bind(&no_op), TestPaths::xsd).empty()); + list<dcp::VerificationNote> const notes = dcp::verify(dirs, boost::bind(&no_op), boost::bind(&no_op), TestPaths::xsd); + dump_notes (notes); + BOOST_REQUIRE (notes.empty()); } |