diff options
| author | Carl Hetherington <cth@carlh.net> | 2026-01-09 01:35:59 +0100 |
|---|---|---|
| committer | Carl Hetherington <cth@carlh.net> | 2026-01-09 01:35:59 +0100 |
| commit | 070986191180139cbd0db632ca0d49e19f96fba8 (patch) | |
| tree | 8ea37a8611f25f3a598dfc3902bdfcb62d0a1128 | |
| parent | 1b4ad92e7e61a56487fbc68b21e60dbd95795561 (diff) | |
Don't keep a shared_ptr to the Job for the whole of the ::go() method.
This fixes a number of weird segfaults/crashes in tests that I didn't get
to the bottom of.
| -rw-r--r-- | src/lib/dcp_film_encoder.cc | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/lib/dcp_film_encoder.cc b/src/lib/dcp_film_encoder.cc index a818c9b4c..6e56b88c8 100644 --- a/src/lib/dcp_film_encoder.cc +++ b/src/lib/dcp_film_encoder.cc @@ -95,8 +95,7 @@ DCPFilmEncoder::~DCPFilmEncoder() void DCPFilmEncoder::go() { - auto job = _job.lock(); - _writer.reset(new Writer(_film, job, _film->dir(_film->dcp_name()))); + _writer.reset(new Writer(_film, _job, _film->dir(_film->dcp_name()))); switch (_film->video_encoding()) { case VideoEncoding::JPEG2000: |