diff options
| author | Carl Hetherington <cth@carlh.net> | 2014-10-05 23:53:54 +0100 |
|---|---|---|
| committer | Carl Hetherington <cth@carlh.net> | 2014-10-05 23:53:54 +0100 |
| commit | ebcdc90fa32c22895b958126ba5a6a4d562616ad (patch) | |
| tree | 7c28509e0f0b7800b46a0fcfd9efb3dabcf9cd43 | |
| parent | 6b4fdbdabeb7b6010b5d558fb231e5d4e69487fc (diff) | |
More sensible default size / position for .srt subs.
| -rw-r--r-- | ChangeLog | 5 | ||||
| -rw-r--r-- | src/lib/subrip_decoder.cc | 7 |
2 files changed, 10 insertions, 2 deletions
@@ -1,3 +1,8 @@ +2014-10-05 Carl Hetherington <cth@carlh.net> + + * Use a more sensible default position and size for + .srt subs. + 2014-10-01 Carl Hetherington <cth@carlh.net> * Version 2.0.13 released. diff --git a/src/lib/subrip_decoder.cc b/src/lib/subrip_decoder.cc index e2bdc347b..2ae285b5e 100644 --- a/src/lib/subrip_decoder.cc +++ b/src/lib/subrip_decoder.cc @@ -52,6 +52,8 @@ SubRipDecoder::pass () if (_next >= _subtitles.size ()) { return true; } + + /* XXX: we are ignoring positioning specified in the file */ list<dcp::SubtitleString> out; for (list<SubRipSubtitlePiece>::const_iterator i = _subtitles[_next].pieces.begin(); i != _subtitles[_next].pieces.end(); ++i) { @@ -60,10 +62,11 @@ SubRipDecoder::pass () "Arial", i->italic, dcp::Color (255, 255, 255), - 72, + /* .srt files don't specify size, so this is an arbitrary value */ + 48, dcp::Time (rint (_subtitles[_next].period.from.seconds() * 250)), dcp::Time (rint (_subtitles[_next].period.to.seconds() * 250)), - 0.9, + 0.2, dcp::BOTTOM, i->text, dcp::NONE, |