summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCarl Hetherington <cth@carlh.net>2020-09-23 15:08:56 +0000
committerCarl Hetherington <cth@carlh.net>2020-09-23 15:08:56 +0000
commitb1ae6e39d31408e5f1eae77fe1de1ac292f54182 (patch)
treead2bb4c335252ea4f48e569dd5c2446d58429a9e
parentc1e8c8638bcb3b4c9d90adc3719f38fa7bf81be9 (diff)
Fix warnings about catching polymorphic types by value (#1843).
-rw-r--r--src/lib/reel_writer.cc2
-rw-r--r--src/tools/dcpomatic_kdm.cc2
-rw-r--r--src/wx/kdm_cpl_panel.cc2
3 files changed, 3 insertions, 3 deletions
diff --git a/src/lib/reel_writer.cc b/src/lib/reel_writer.cc
index 071cab12a..84923c202 100644
--- a/src/lib/reel_writer.cc
+++ b/src/lib/reel_writer.cc
@@ -211,7 +211,7 @@ ReelWriter::check_existing_picture_asset ()
try {
info_file = _film->info_file_handle (_period, true);
- } catch (OpenFileError) {
+ } catch (OpenFileError &) {
LOG_GENERAL_NC ("Could not open film info file");
fclose (asset_file);
return 0;
diff --git a/src/tools/dcpomatic_kdm.cc b/src/tools/dcpomatic_kdm.cc
index 6c1fbd800..3b97fa2da 100644
--- a/src/tools/dcpomatic_kdm.cc
+++ b/src/tools/dcpomatic_kdm.cc
@@ -437,7 +437,7 @@ private:
std_to_wx(e.what())
);
return;
- } catch (dcp::KDMDecryptionError) {
+ } catch (dcp::KDMDecryptionError &) {
error_dialog (
this,
_("Could not decrypt the DKDM. Perhaps it was not created with the correct certificate.")
diff --git a/src/wx/kdm_cpl_panel.cc b/src/wx/kdm_cpl_panel.cc
index 967fb2845..8b4d93129 100644
--- a/src/wx/kdm_cpl_panel.cc
+++ b/src/wx/kdm_cpl_panel.cc
@@ -143,7 +143,7 @@ KDMCPLPanel::cpl_browse_clicked ()
0
)
);
- } catch (cxml::Error) {
+ } catch (cxml::Error &) {
error_dialog (this, _("This is not a valid CPL file"));
return;
}