summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCarl Hetherington <cth@carlh.net>2018-05-08 00:49:33 +0100
committerCarl Hetherington <cth@carlh.net>2018-05-08 00:49:33 +0100
commit4a23fb5dd58c6439f240f678be2e26a5bee17881 (patch)
treea8f0729f30622a7fb0ab57ae11f862666a42368a
parentcebabb10b6055a168ac3aa1470751e17898a3b89 (diff)
Add colour, effect and effect colour to ::identifier() to force remake of video when they change (#1290).
-rw-r--r--ChangeLog5
-rw-r--r--src/lib/subtitle_content.cc5
2 files changed, 9 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog
index bbbee5ff9..e397d7952 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2018-05-08 Carl Hetherington <cth@carlh.net>
+
+ * Look at subtitle colour and effect when deciding whether or not to
+ re-make video (should fix #1290).
+
2018-05-07 Carl Hetherington <cth@carlh.net>
* Updated cs_CZ translation from Tomáš Begeni.
diff --git a/src/lib/subtitle_content.cc b/src/lib/subtitle_content.cc
index 9e3ed3229..cd9363839 100644
--- a/src/lib/subtitle_content.cc
+++ b/src/lib/subtitle_content.cc
@@ -319,7 +319,10 @@ SubtitleContent::identifier () const
+ "_" + raw_convert<string> (line_spacing())
+ "_" + raw_convert<string> (fade_in().get_value_or(ContentTime()).get())
+ "_" + raw_convert<string> (fade_out().get_value_or(ContentTime()).get())
- + "_" + raw_convert<string> (outline_width());
+ + "_" + raw_convert<string> (outline_width())
+ + "_" + raw_convert<string> (colour().get_value_or(dcp::Colour(255, 255, 255)).to_argb_string())
+ + "_" + raw_convert<string> (dcp::effect_to_string(effect().get_value_or(dcp::NONE)))
+ + "_" + raw_convert<string> (effect_colour().get_value_or(dcp::Colour(0, 0, 0)).to_argb_string());
/* XXX: I suppose really _fonts shouldn't be in here, since not all
types of subtitle content involve fonts.