Fix ridiculous thinko causing repeated calls to FcConfigAppFontAddFile and hence memory leak (may fix #766).

2 files changed, 6 insertions, 2 deletions

diff --git a/ChangeLog b/ChangeLog
index f7961f64e..24aa9973c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2015-11-29  Carl Hetherington  <cth@carlh.net>
+
+	* Possibly fix large memory use with burnt-in subtitles (#766).
+
 2015-11-28  Carl Hetherington  <cth@carlh.net>
 
 	* Version 2.5.11 released.
diff --git a/src/lib/font_files.cc b/src/lib/font_files.cc
index 65b67f7b3..61da986bf 100644
--- a/src/lib/font_files.cc
+++ b/src/lib/font_files.cc
@@ -24,9 +24,9 @@ operator!= (FontFiles const & a, FontFiles const & b)
 {
 	for (int i = 0; i < FontFiles::VARIANTS; ++i) {
 		if (a.get(static_cast<FontFiles::Variant>(i)) != b.get(static_cast<FontFiles::Variant>(i))) {
-			return false;
+			return true;
 		}
 	}
 
-	return true;
+	return false;
 }