summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCarl Hetherington <cth@carlh.net>2023-07-25 11:09:46 +0200
committerCarl Hetherington <cth@carlh.net>2023-08-06 22:05:03 +0200
commite8749cfcef2b9434377e73c66a79755691ebc064 (patch)
tree9eec3c649173a63d9ba667d840911724fefe137b
parent02d4493e593d567b210cd7f2b98d33a345867d1d (diff)
Default to writing 8 audio channels in DCPs (#2443).
It seems likely that 8 channels is slightly less likely to trip validation warnings from some distributors, and so it seems worth accepting the potential waste of 2 channels. Users can always set this back to 6 again (once, and it will be saved) and those upgrading from old versions won't be affected anyway.
-rw-r--r--src/lib/config.cc2
-rw-r--r--test/film_metadata_test.cc1
2 files changed, 2 insertions, 1 deletions
diff --git a/src/lib/config.cc b/src/lib/config.cc
index 3366a2bbc..fdce75109 100644
--- a/src/lib/config.cc
+++ b/src/lib/config.cc
@@ -106,7 +106,7 @@ Config::set_defaults ()
_language = optional<string> ();
_default_still_length = 10;
_default_dcp_content_type = DCPContentType::from_isdcf_name ("FTR");
- _default_dcp_audio_channels = 6;
+ _default_dcp_audio_channels = 8;
_default_j2k_bandwidth = 150000000;
_default_audio_delay = 0;
_default_interop = false;
diff --git a/test/film_metadata_test.cc b/test/film_metadata_test.cc
index ada943c80..878e60254 100644
--- a/test/film_metadata_test.cc
+++ b/test/film_metadata_test.cc
@@ -63,6 +63,7 @@ BOOST_AUTO_TEST_CASE (film_metadata_test)
film->set_distributor (string(""));
film->set_facility (string(""));
film->set_release_territory (dcp::LanguageTag::RegionSubtag("US"));
+ film->set_audio_channels(6);
film->write_metadata ();
list<string> ignore = { "Key", "ContextID", "LastWrittenBy" };