diff options
| author | Carl Hetherington <cth@carlh.net> | 2018-02-27 22:36:09 +0000 |
|---|---|---|
| committer | Carl Hetherington <cth@carlh.net> | 2018-02-27 22:36:09 +0000 |
| commit | 2203c698eb6661a1f531b0708757354fc8cc9784 (patch) | |
| tree | 784300f27b43af3199f3dc0ff8c57bf6d06f17ba | |
| parent | 363dee03e61d65538841541028ed62c91ffca124 (diff) | |
Add a hint to warn about the stereo-to-5.1 upmixers.
| -rw-r--r-- | ChangeLog | 5 | ||||
| -rw-r--r-- | src/lib/hints.cc | 8 |
2 files changed, 12 insertions, 1 deletions
@@ -1,3 +1,8 @@ +2018-02-27 Carl Hetherington <cth@carlh.net> + + * Add a hint about the stereo-to-5.1 upmixers being + `experimental'. + 2018-02-25 Carl Hetherington <cth@carlh.net> * Updated es_ES translation from Manuel AC. diff --git a/src/lib/hints.cc b/src/lib/hints.cc index b5edd7cc4..62e04f499 100644 --- a/src/lib/hints.cc +++ b/src/lib/hints.cc @@ -1,5 +1,5 @@ /* - Copyright (C) 2016-2017 Carl Hetherington <cth@carlh.net> + Copyright (C) 2016-2018 Carl Hetherington <cth@carlh.net> This file is part of DCP-o-matic. @@ -24,6 +24,7 @@ #include "content.h" #include "video_content.h" #include "subtitle_content.h" +#include "audio_processor.h" #include "font.h" #include "ratio.h" #include "audio_analysis.h" @@ -76,6 +77,11 @@ get_hints (shared_ptr<const Film> film) hints.push_back (_("Your DCP has fewer than 6 audio channels. This may cause problems on some projectors.")); } + AudioProcessor const * ap = film->audio_processor(); + if (ap && (ap->id() == "stereo-5.1-upmix-a" || ap->id() == "stereo-5.1-upmix-b")) { + hints.push_back (_("You are using DCP-o-matic's stereo-to-5.1 upmixer. This is experimental and may result in poor-quality audio. If you continue, you should listen to the resulting DCP in a cinema to make sure that it sounds good.")); + } + int flat_or_narrower = 0; int scope = 0; BOOST_FOREACH (shared_ptr<const Content> i, content) { |