diff options
| author | Carl Hetherington <cth@carlh.net> | 2022-02-24 19:47:19 +0100 |
|---|---|---|
| committer | Carl Hetherington <cth@carlh.net> | 2022-03-03 21:54:38 +0100 |
| commit | a190ee3b457cf9be650556ce0496415bcd3b9e7b (patch) | |
| tree | 8663d6807b9ab5d77f733c571a753d3866f0b47f /src/lib/encode_server_finder.h | |
| parent | 5ea930a778ea350c5e3d1adc45d84b075cfdbaa0 (diff) | |
Fix some dubious thread/locking behaviour.
Previously we had server_found(), which took the lock and found
a server, which it returned as an iterator into the list.
However, it then released the lock, which I think left the
iterator unprotected.
This wasn't done in response to any particular bug, I just
noticed it on the way past.
Diffstat (limited to 'src/lib/encode_server_finder.h')
| -rw-r--r-- | src/lib/encode_server_finder.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/lib/encode_server_finder.h b/src/lib/encode_server_finder.h index 533c9219b..efb498880 100644 --- a/src/lib/encode_server_finder.h +++ b/src/lib/encode_server_finder.h @@ -66,7 +66,6 @@ private: void search_thread (); void listen_thread (); - boost::optional<std::list<EncodeServerDescription>::iterator> server_found (std::string); void start_accept (); void handle_accept (boost::system::error_code ec, std::shared_ptr<Socket> socket); |