summaryrefslogtreecommitdiff
path: root/src/lib/hints.cc
diff options
context:
space:
mode:
authorCarl Hetherington <cth@carlh.net>2021-04-10 00:23:35 +0200
committerCarl Hetherington <cth@carlh.net>2021-04-10 00:23:35 +0200
commit3a141d70f95dc447644197832f56c04e83cd49cb (patch)
treea32a22fe341db1706ba82a340be9447fc82aeb79 /src/lib/hints.cc
parent0f8227817cfde6079c28fb18bbab11d9105d2bfc (diff)
Add a hint about >79 length subtitles.
Diffstat (limited to 'src/lib/hints.cc')
-rw-r--r--src/lib/hints.cc15
1 files changed, 6 insertions, 9 deletions
diff --git a/src/lib/hints.cc b/src/lib/hints.cc
index 3c9339cc7..ea524df50 100644
--- a/src/lib/hints.cc
+++ b/src/lib/hints.cc
@@ -76,14 +76,6 @@ using namespace boost::placeholders;
Hints::Hints (weak_ptr<const Film> film)
: WeakConstFilm (film)
, _writer (new Writer(film, weak_ptr<Job>(), true))
- , _long_ccap (false)
- , _overlap_ccap (false)
- , _too_many_ccap_lines (false)
- , _early_subtitle (false)
- , _short_subtitle (false)
- , _subtitles_too_close (false)
- , _too_many_subtitle_lines (false)
- , _long_subtitle (false)
, _stop (false)
{
@@ -564,7 +556,12 @@ Hints::open_subtitle (PlayerText text, DCPTimePeriod period)
if (longest_line > 52 && !_long_subtitle) {
_long_subtitle = true;
- hint (_("At least one of your subtitle lines has more than 52 characters. It is advisable to make each line 52 characters at most in length."));
+ hint (_("At least one of your subtitle lines has more than 52 characters. It is recommended to make each line 52 characters at most in length."));
+ }
+
+ if (longest_line > 79 && !_very_long_subtitle) {
+ _very_long_subtitle = true;
+ hint (_("At least one of your subtitle lines has more than 79 characters. You should make each line 79 characters at most in length."));
}
_last_subtitle = period;