summaryrefslogtreecommitdiff
path: root/src/lib/magick_image_proxy.cc
diff options
context:
space:
mode:
authorCarl Hetherington <cth@carlh.net>2014-09-09 21:52:05 +0100
committerCarl Hetherington <cth@carlh.net>2014-09-09 21:52:05 +0100
commit39029279954b1f346d3ba28ec12c58211bfa7436 (patch)
treec225a1fbcb4f5af7866d3eee8970cd500129a54d /src/lib/magick_image_proxy.cc
parent0c3155bda8935bf597535f4e38f65568e55093eb (diff)
parent087eb941421d0ced97c8f3bf72072f19562435df (diff)
Merge master.
Diffstat (limited to 'src/lib/magick_image_proxy.cc')
-rw-r--r--src/lib/magick_image_proxy.cc25
1 files changed, 23 insertions, 2 deletions
diff --git a/src/lib/magick_image_proxy.cc b/src/lib/magick_image_proxy.cc
index 0908ed921..4adf8047f 100644
--- a/src/lib/magick_image_proxy.cc
+++ b/src/lib/magick_image_proxy.cc
@@ -30,6 +30,7 @@
#define LOG_TIMING(...) _log->microsecond_log (String::compose (__VA_ARGS__), Log::TYPE_TIMING);
+using std::string;
using boost::shared_ptr;
MagickImageProxy::MagickImageProxy (boost::filesystem::path path, shared_ptr<Log> log)
@@ -74,10 +75,30 @@ MagickImageProxy::image () const
LOG_TIMING ("[%1] MagickImageProxy begins decode and convert of %2 bytes", boost::this_thread::get_id(), _blob.length());
Magick::Image* magick_image = 0;
+ string error;
try {
magick_image = new Magick::Image (_blob);
- } catch (...) {
- throw DecodeError (_("Could not decode image file"));
+ } catch (Magick::Exception& e) {
+ error = e.what ();
+ }
+
+ if (!magick_image) {
+ /* ImageMagick cannot auto-detect Targa files, it seems, so try here with an
+ explicit format. I can't find it documented that passing a (0, 0) geometry
+ is allowed, but it seems to work.
+ */
+ try {
+ magick_image = new Magick::Image (_blob, Magick::Geometry (0, 0), "TGA");
+ } catch (...) {
+
+ }
+ }
+
+ if (!magick_image) {
+ /* If we failed both an auto-detect and a forced-Targa we give the error from
+ the auto-detect.
+ */
+ throw DecodeError (String::compose (_("Could not decode image file (%1)"), error));
}
dcp::Size size (magick_image->columns(), magick_image->rows());