Tidy up logging a bit. Make it configurable from the GUI.

1 files changed, 22 insertions, 19 deletions

diff --git a/src/lib/writer.cc b/src/lib/writer.cc
index 639685149..b058c2801 100644
--- a/src/lib/writer.cc
+++ b/src/lib/writer.cc
@@ -40,6 +40,10 @@
 
 #include "i18n.h"
 
+#define LOG_GENERAL(...) _film->log()->log (String::compose (__VA_ARGS__), Log::GENERAL);
+#define LOG_TIMING(...) _film->log()->microsecond_log (String::compose (__VA_ARGS__), Log::TIMING);
+#define LOG_WARNING_NC(...) _film->log()->log (__VA_ARGS__, Log::WARNING);
+
 /* OS X strikes again */
 #undef set_key
 
@@ -239,9 +243,9 @@ try
 				break;
 			}
 
-			TIMING (N_("writer sleeps with a queue of %1"), _queue.size());
+			LOG_TIMING (N_("writer sleeps with a queue of %1"), _queue.size());
 			_empty_condition.wait (lock);
-			TIMING (N_("writer wakes with a queue of %1"), _queue.size());
+			LOG_TIMING (N_("writer wakes with a queue of %1"), _queue.size());
 		}
 
 		if (_finish && _queue.empty()) {
@@ -260,7 +264,7 @@ try
 			switch (qi.type) {
 			case QueueItem::FULL:
 			{
-				_film->log()->log (String::compose (N_("Writer FULL-writes %1 to MXF"), qi.frame));
+				LOG_GENERAL (N_("Writer FULL-writes %1 to MXF"), qi.frame);
 				if (!qi.encoded) {
 					qi.encoded.reset (new EncodedData (_film->j2c_path (qi.frame, qi.eyes, false)));
 				}
@@ -272,14 +276,14 @@ try
 				break;
 			}
 			case QueueItem::FAKE:
-				_film->log()->log (String::compose (N_("Writer FAKE-writes %1 to MXF"), qi.frame));
+				LOG_GENERAL (N_("Writer FAKE-writes %1 to MXF"), qi.frame);
 				_picture_asset_writer->fake_write (qi.size);
 				_last_written[qi.eyes].reset ();
 				++_fake_written;
 				break;
 			case QueueItem::REPEAT:
 			{
-				_film->log()->log (String::compose (N_("Writer REPEAT-writes %1 to MXF"), qi.frame));
+				LOG_GENERAL (N_("Writer REPEAT-writes %1 to MXF"), qi.frame);
 				libdcp::FrameInfo fin = _picture_asset_writer->write (
 					_last_written[qi.eyes]->data(),
 					_last_written[qi.eyes]->size()
@@ -328,11 +332,10 @@ try
 			
 			lock.unlock ();
 
-			_film->log()->log (
-				String::compose (
-					"Writer full (awaiting %1 [last eye was %2]); pushes %3 to disk",
-					_last_written_frame + 1,
-					_last_written_eyes, qi.frame)
+			LOG_GENERAL (
+				"Writer full (awaiting %1 [last eye was %2]); pushes %3 to disk",
+				_last_written_frame + 1,
+				_last_written_eyes, qi.frame
 				);
 			
 			qi.encoded->write (_film, qi.frame, qi.eyes);
@@ -403,7 +406,7 @@ Writer::finish ()
 	if (ec) {
 		/* hard link failed; copy instead */
 		boost::filesystem::copy_file (video_from, video_to);
-		_film->log()->log ("Hard-link failed; fell back to copying");
+		LOG_WARNING_NC ("Hard-link failed; fell back to copying");
 	}
 
 	/* And update the asset */
@@ -465,8 +468,8 @@ Writer::finish ()
 	meta.set_issue_date_now ();
 	dcp.write_xml (_film->interop (), meta, _film->is_signed() ? make_signer () : shared_ptr<const libdcp::Signer> ());
 
-	_film->log()->log (
-		String::compose (N_("Wrote %1 FULL, %2 FAKE, %3 REPEAT; %4 pushed to disk"), _full_written, _fake_written, _repeat_written, _pushed_to_disk)
+	LOG_GENERAL (
+		N_("Wrote %1 FULL, %2 FAKE, %3 REPEAT; %4 pushed to disk"), _full_written, _fake_written, _repeat_written, _pushed_to_disk
 		);
 }
 
@@ -502,14 +505,14 @@ Writer::check_existing_picture_mxf_frame (FILE* mxf, int f, Eyes eyes)
 	/* Read the frame info as written */
 	FILE* ifi = fopen_boost (_film->info_path (f, eyes), "r");
 	if (!ifi) {
-		_film->log()->log (String::compose ("Existing frame %1 has no info file", f));
+		LOG_GENERAL ("Existing frame %1 has no info file", f);
 		return false;
 	}
 	
 	libdcp::FrameInfo info (ifi);
 	fclose (ifi);
 	if (info.size == 0) {
-		_film->log()->log (String::compose ("Existing frame %1 has no info file", f));
+		LOG_GENERAL ("Existing frame %1 has no info file", f);
 		return false;
 	}
 	
@@ -518,13 +521,13 @@ Writer::check_existing_picture_mxf_frame (FILE* mxf, int f, Eyes eyes)
 	EncodedData data (info.size);
 	size_t const read = fread (data.data(), 1, data.size(), mxf);
 	if (read != static_cast<size_t> (data.size ())) {
-		_film->log()->log (String::compose ("Existing frame %1 is incomplete", f));
+		LOG_GENERAL ("Existing frame %1 is incomplete", f);
 		return false;
 	}
 	
 	string const existing_hash = md5_digest (data.data(), data.size());
 	if (existing_hash != info.hash) {
-		_film->log()->log (String::compose ("Existing frame %1 failed hash check", f));
+		LOG_GENERAL ("Existing frame %1 failed hash check", f);
 		return false;
 	}
 
@@ -540,7 +543,7 @@ Writer::check_existing_picture_mxf ()
 	p /= _film->internal_video_mxf_filename ();
 	FILE* mxf = fopen_boost (p, "rb");
 	if (!mxf) {
-		_film->log()->log (String::compose ("Could not open existing MXF at %1 (errno=%2)", p.string(), errno));
+		LOG_GENERAL ("Could not open existing MXF at %1 (errno=%2)", p.string(), errno);
 		return;
 	}
 
@@ -571,7 +574,7 @@ Writer::check_existing_picture_mxf ()
 			}
 		}
 
-		_film->log()->log (String::compose ("Have existing frame %1", _first_nonexistant_frame));
+		LOG_GENERAL ("Have existing frame %1", _first_nonexistant_frame);
 		++_first_nonexistant_frame;
 	}