Don't start thread in constructor. (Writer)

1 files changed, 4 insertions, 5 deletions

diff --git a/src/lib/writer.cc b/src/lib/writer.cc
index 9c4a194e8..0e15edeca 100644
--- a/src/lib/writer.cc
+++ b/src/lib/writer.cc
@@ -148,12 +148,11 @@ Writer::Writer (shared_ptr<const Film> film, weak_ptr<Job> j)
 	}
 
 	job->sub (_("Encoding image data"));
+}
 
-	/* Do this last; if something after this line were to throw an exception
-	   (say if Job::sub was interrupted by cancel) this thread would never
-	   get properly cleaned up but the Writer object would go away underneath
-	   it.
-	*/
+void
+Writer::start ()
+{
 	_thread = new boost::thread (boost::bind (&Writer::thread, this));
 }