diff options
| author | Carl Hetherington <cth@carlh.net> | 2017-01-04 21:41:07 +0000 |
|---|---|---|
| committer | Carl Hetherington <cth@carlh.net> | 2017-01-04 21:41:07 +0000 |
| commit | 736f9d8154080ea5837b31af623ef863eea1a7c5 (patch) | |
| tree | ddb5c8118d57b9f55d507293b75e0d5fd9652811 /src/lib | |
| parent | 11ac33e140f3aa9d6e992880a1e1b3a4ca649355 (diff) | |
Fix non-frame-aligned trims when using trim-to-playhead.
Reimplement Time::ceil and add a corresponding Time::floor with tests.
ceil returns slightly different results to previously with non-integer
frame rates.
Then use floor to round the playhead position when trimming.
Diffstat (limited to 'src/lib')
| -rw-r--r-- | src/lib/dcpomatic_time.h | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/src/lib/dcpomatic_time.h b/src/lib/dcpomatic_time.h index 6834ee099..16d93ca28 100644 --- a/src/lib/dcpomatic_time.h +++ b/src/lib/dcpomatic_time.h @@ -119,9 +119,11 @@ public: * @param r Sampling rate. */ Time<S, O> ceil (float r) const { - Type const n = llrintf (HZ / r); - Type const a = _t + n - 1; - return Time<S, O> (a - (a % n)); + return Time<S, O> (llrint (HZ * frames_ceil(r) / double(r))); + } + + Time<S, O> floor (float r) const { + return Time<S, O> (llrint (HZ * frames_floor(r) / double(r))); } double seconds () const { @@ -143,7 +145,7 @@ public: template <typename T> int64_t frames_floor (T r) const { - return floor (_t * r / HZ); + return ::floor (_t * r / HZ); } template <typename T> @@ -212,6 +214,7 @@ public: private: friend struct dcptime_ceil_test; + friend struct dcptime_floor_test; Type _t; static const int HZ = 96000; |
