Add some missing test stuff; split server discovery off into ServerFinder.

5 files changed, 180 insertions, 89 deletions

diff --git a/src/lib/encoder.cc b/src/lib/encoder.cc
index a442e64d0..2ec32deb7 100644
--- a/src/lib/encoder.cc
+++ b/src/lib/encoder.cc
@@ -33,6 +33,7 @@
 #include "server.h"
 #include "cross.h"
 #include "writer.h"
+#include "server_finder.h"
 
 #include "i18n.h"
 
@@ -56,8 +57,6 @@ Encoder::Encoder (shared_ptr<const Film> f, shared_ptr<Job> j)
 	, _job (j)
 	, _video_frames_out (0)
 	, _terminate (false)
-	, _broadcast_thread (0)
-	, _listen_thread (0)
 {
 	_have_a_real_frame[EYES_BOTH] = false;
 	_have_a_real_frame[EYES_LEFT] = false;
@@ -104,10 +103,9 @@ Encoder::process_begin ()
 		add_worker_threads (*i);
 	}
 
-	_broadcast_thread = new boost::thread (boost::bind (&Encoder::broadcast_thread, this));
-	_listen_thread = new boost::thread (boost::bind (&Encoder::listen_thread, this));
-
 	_writer.reset (new Writer (_film, _job));
+	_server_finder.reset (new ServerFinder ());
+	_server_finder->ServerFound.connect (boost::bind (&Encoder::server_found, this, _1));
 }
 
 
@@ -267,16 +265,6 @@ Encoder::terminate_threads ()
 	}
 
 	_threads.clear ();
-		     
-	if (_broadcast_thread && _broadcast_thread->joinable ()) {
-		_broadcast_thread->join ();
-	}
-	delete _broadcast_thread;
-
-	if (_listen_thread && _listen_thread->joinable ()) {
-		_listen_thread->join ();
-	}
-	delete _listen_thread;
 }
 
 void
@@ -364,76 +352,16 @@ Encoder::encoder_thread (optional<ServerDescription> server)
 }
 
 void
-Encoder::broadcast_thread ()
+Encoder::server_found (ServerDescription s)
 {
-	boost::system::error_code error;
-	boost::asio::io_service io_service;
-	boost::asio::ip::udp::socket socket (io_service);
-	socket.open (boost::asio::ip::udp::v4(), error);
-	if (error) {
-		throw NetworkError ("failed to set up broadcast socket");
+	/* See if we already know about this server */
+	boost::mutex::scoped_lock lm (_mutex);
+	ThreadList::iterator i = _threads.begin();
+	while (i != _threads.end() && (!i->first || i->first.get().host_name() != s.host_name())) {
+		++i;
 	}
-
-        socket.set_option (boost::asio::ip::udp::socket::reuse_address (true));
-        socket.set_option (boost::asio::socket_base::broadcast (true));
 	
-        boost::asio::ip::udp::endpoint end_point (boost::asio::ip::address_v4::broadcast(), Config::instance()->server_port_base() + 1);            
-
-	while (1) {
-		boost::mutex::scoped_lock lm (_mutex);
-		if (_terminate) {
-			socket.close (error);
-			return;
-		}
-		
-		string data = DCPOMATIC_HELLO;
-		socket.send_to (boost::asio::buffer (data.c_str(), data.size() + 1), end_point);
-
-		lm.unlock ();
-		dcpomatic_sleep (10);
-	}
-}
-
-void
-Encoder::listen_thread ()
-{
-	while (1) {
-		{
-			/* See if we need to stop */
-			boost::mutex::scoped_lock lm (_mutex);
-			if (_terminate) {
-				return;
-			}
-		}
-
-		shared_ptr<Socket> sock (new Socket (10));
-
-		try {
-			sock->accept (Config::instance()->server_port_base() + 1);
-		} catch (std::exception& e) {
-			continue;
-		}
-
-		uint32_t length = sock->read_uint32 ();
-		scoped_array<char> buffer (new char[length]);
-		sock->read (reinterpret_cast<uint8_t*> (buffer.get()), length);
-		
-		stringstream s (buffer.get());
-		shared_ptr<cxml::Document> xml (new cxml::Document ("ServerAvailable"));
-		xml->read_stream (s);
-
-		{
-			/* See if we already know about this server */
-			string const ip = sock->socket().remote_endpoint().address().to_string ();
-			boost::mutex::scoped_lock lm (_mutex);
-			ThreadList::iterator i = _threads.begin();
-			while (i != _threads.end() && (!i->first || i->first->host_name() != ip)) {
-				++i;
-			}
-
-			if (i == _threads.end ()) {
-				add_worker_threads (ServerDescription (ip, xml->number_child<int> ("Threads")));
-			}
-		}
+	if (i == _threads.end ()) {
+		add_worker_threads (s);
 	}
 }
diff --git a/src/lib/encoder.h b/src/lib/encoder.h
index 9fcba560f..902dae2d5 100644
--- a/src/lib/encoder.h
+++ b/src/lib/encoder.h
@@ -46,6 +46,7 @@ class DCPVideoFrame;
 class EncodedData;
 class Writer;
 class Job;
+class ServerFinder;
 
 /** @class Encoder
  *  @brief Encoder to J2K and WAV for DCP.
@@ -84,9 +85,8 @@ private:
 	
 	void encoder_thread (boost::optional<ServerDescription>);
 	void terminate_threads ();
-	void broadcast_thread ();
-	void listen_thread ();
 	void add_worker_threads (ServerDescription);
+	void server_found (ServerDescription);
 
 	/** Film that we are encoding */
 	boost::shared_ptr<const Film> _film;
@@ -113,10 +113,7 @@ private:
 	boost::condition _condition;
 
 	boost::shared_ptr<Writer> _writer;
-
-	/** A thread to periodically issue broadcasts to find encoding servers */
-	boost::thread* _broadcast_thread;
-	boost::thread* _listen_thread;
+	boost::shared_ptr<ServerFinder> _server_finder;
 };
 
 #endif
diff --git a/src/lib/server_finder.cc b/src/lib/server_finder.cc
new file mode 100644
index 000000000..c0b554eee
--- /dev/null
+++ b/src/lib/server_finder.cc
@@ -0,0 +1,124 @@
+/*
+    Copyright (C) 2013 Carl Hetherington <cth@carlh.net>
+
+    This program is free software; you can redistribute it and/or modify
+    it under the terms of the GNU General Public License as published by
+    the Free Software Foundation; either version 2 of the License, or
+    (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+    GNU General Public License for more details.
+
+    You should have received a copy of the GNU General Public License
+    along with this program; if not, write to the Free Software
+    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+
+*/
+
+#include <libcxml/cxml.h>
+#include "server_finder.h"
+#include "exceptions.h"
+#include "util.h"
+#include "config.h"
+#include "cross.h"
+#include "ui_signaller.h"
+
+using std::string;
+using std::stringstream;
+using boost::shared_ptr;
+using boost::scoped_array;
+
+ServerFinder::ServerFinder ()
+	: _broadcast_thread (0)
+	, _listen_thread (0)
+	, _terminate (false)
+{
+	_broadcast_thread = new boost::thread (boost::bind (&ServerFinder::broadcast_thread, this));
+	_listen_thread = new boost::thread (boost::bind (&ServerFinder::listen_thread, this));
+}
+
+ServerFinder::~ServerFinder ()
+{
+	{
+		boost::mutex::scoped_lock lm (_mutex);
+		_terminate = true;
+	}
+	
+	if (_broadcast_thread && _broadcast_thread->joinable ()) {
+		_broadcast_thread->join ();
+	}
+	delete _broadcast_thread;
+
+	if (_listen_thread && _listen_thread->joinable ()) {
+		_listen_thread->join ();
+	}
+	delete _listen_thread;
+}
+
+void
+ServerFinder::broadcast_thread ()
+{
+	boost::system::error_code error;
+	boost::asio::io_service io_service;
+	boost::asio::ip::udp::socket socket (io_service);
+	socket.open (boost::asio::ip::udp::v4(), error);
+	if (error) {
+		throw NetworkError ("failed to set up broadcast socket");
+	}
+
+        socket.set_option (boost::asio::ip::udp::socket::reuse_address (true));
+        socket.set_option (boost::asio::socket_base::broadcast (true));
+	
+        boost::asio::ip::udp::endpoint end_point (boost::asio::ip::address_v4::broadcast(), Config::instance()->server_port_base() + 1);            
+
+	while (1) {
+		boost::mutex::scoped_lock lm (_mutex);
+		if (_terminate) {
+			socket.close (error);
+			return;
+		}
+		
+		string data = DCPOMATIC_HELLO;
+		socket.send_to (boost::asio::buffer (data.c_str(), data.size() + 1), end_point);
+
+		lm.unlock ();
+		dcpomatic_sleep (10);
+	}
+}
+
+void
+ServerFinder::listen_thread ()
+{
+	while (1) {
+		{
+			/* See if we need to stop */
+			boost::mutex::scoped_lock lm (_mutex);
+			if (_terminate) {
+				return;
+			}
+		}
+
+		shared_ptr<Socket> sock (new Socket (10));
+
+		try {
+			sock->accept (Config::instance()->server_port_base() + 1);
+		} catch (std::exception& e) {
+			continue;
+		}
+
+		uint32_t length = sock->read_uint32 ();
+		scoped_array<char> buffer (new char[length]);
+		sock->read (reinterpret_cast<uint8_t*> (buffer.get()), length);
+		
+		stringstream s (buffer.get());
+		shared_ptr<cxml::Document> xml (new cxml::Document ("ServerAvailable"));
+		xml->read_stream (s);
+
+		ui_signaller->emit (boost::bind (boost::ref (ServerFound), ServerDescription (
+							 sock->socket().remote_endpoint().address().to_string (),
+							 xml->number_child<int> ("Threads")
+							 )));
+	}
+}
diff --git a/src/lib/server_finder.h b/src/lib/server_finder.h
new file mode 100644
index 000000000..8b56022de
--- /dev/null
+++ b/src/lib/server_finder.h
@@ -0,0 +1,41 @@
+/*
+    Copyright (C) 2013 Carl Hetherington <cth@carlh.net>
+
+    This program is free software; you can redistribute it and/or modify
+    it under the terms of the GNU General Public License as published by
+    the Free Software Foundation; either version 2 of the License, or
+    (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+    GNU General Public License for more details.
+
+    You should have received a copy of the GNU General Public License
+    along with this program; if not, write to the Free Software
+    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+
+*/
+
+#include <boost/signals2.hpp>
+#include "server.h"
+
+class ServerFinder
+{
+public:
+	ServerFinder ();
+	~ServerFinder ();
+
+	boost::signals2::signal<void (ServerDescription)> ServerFound;
+
+private:
+	void broadcast_thread ();
+	void listen_thread ();
+	
+	/** A thread to periodically issue broadcasts to find encoding servers */
+	boost::thread* _broadcast_thread;
+	boost::thread* _listen_thread;
+
+	bool _terminate;
+	boost::mutex _mutex;
+};
diff --git a/src/lib/wscript b/src/lib/wscript
index e27cf3cc7..7d7803ed5 100644
--- a/src/lib/wscript
+++ b/src/lib/wscript
@@ -44,6 +44,7 @@ sources = """
           scp_dcp_job.cc
           scaler.cc
           server.cc
+          server_finder.cc
           sndfile_content.cc
           sndfile_decoder.cc
           sound_processor.cc