summaryrefslogtreecommitdiff
path: root/src/tools/dcpomatic_editor.cc
diff options
context:
space:
mode:
authorCarl Hetherington <cth@carlh.net>2023-04-25 11:03:54 +0200
committerCarl Hetherington <cth@carlh.net>2023-04-25 11:03:56 +0200
commit293f82daa07bbc357940e5dd214f7c534bab0a86 (patch)
treefb604e1508c04e31336c0c121afadc0662369686 /src/tools/dcpomatic_editor.cc
parente87f943433216d294b22853411eca5c582be1066 (diff)
Don't use wx_ptr for the splash screen.
Using wx_ptr in the wxApp object seems bad because in ~App wxWidgets deletes all top-level windows in `DeleteAllTLWs` so if ~wx_ptr then tries to destroy them we get a use-after-free.
Diffstat (limited to 'src/tools/dcpomatic_editor.cc')
-rw-r--r--src/tools/dcpomatic_editor.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/tools/dcpomatic_editor.cc b/src/tools/dcpomatic_editor.cc
index 663eb8e3b..a61a17ce4 100644
--- a/src/tools/dcpomatic_editor.cc
+++ b/src/tools/dcpomatic_editor.cc
@@ -428,7 +428,7 @@ private:
bool OnInit () override
{
- wx_ptr<wxSplashScreen> splash;
+ wxSplashScreen* splash;
try {
wxInitAllImageHandlers ();