diff options
| author | Carl Hetherington <cth@carlh.net> | 2025-02-09 02:06:04 +0100 |
|---|---|---|
| committer | Carl Hetherington <cth@carlh.net> | 2025-02-09 17:29:16 +0100 |
| commit | d0308d53dd9f4d036d8c5fe8023920fcdfd43f39 (patch) | |
| tree | 5b37c1db5dc50e541a542663390061f743fe815a /src/wx/dcp_panel.cc | |
| parent | 8d0d9866ae3e0395d899705e27b3806a5de7ef0e (diff) | |
Remove unnecessary wx_ptr
It was only ever used for wxDialog subclasses, which can be
stack-allocated.
Diffstat (limited to 'src/wx/dcp_panel.cc')
| -rw-r--r-- | src/wx/dcp_panel.cc | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/src/wx/dcp_panel.cc b/src/wx/dcp_panel.cc index 5a8d49e02..3d28a3ae5 100644 --- a/src/wx/dcp_panel.cc +++ b/src/wx/dcp_panel.cc @@ -339,7 +339,7 @@ DCPPanel::resolution_changed () void DCPPanel::markers_clicked () { - _markers_dialog.reset(_panel, _film, _viewer); + _markers_dialog.emplace(_panel, _film, _viewer); _markers_dialog->Show(); } @@ -348,11 +348,11 @@ void DCPPanel::metadata_clicked () { if (_film->interop()) { - _interop_metadata_dialog.reset(_panel, _film); + _interop_metadata_dialog.emplace(_panel, _film); _interop_metadata_dialog->setup (); _interop_metadata_dialog->Show (); } else { - _smpte_metadata_dialog.reset(_panel, _film); + _smpte_metadata_dialog.emplace(_panel, _film); _smpte_metadata_dialog->setup (); _smpte_metadata_dialog->Show (); } @@ -362,7 +362,7 @@ DCPPanel::metadata_clicked () void DCPPanel::reels_clicked() { - _dcp_timeline.reset(_panel, _film); + _dcp_timeline.emplace(_panel, _film); _dcp_timeline->Show(); } @@ -1029,7 +1029,7 @@ DCPPanel::show_audio_clicked () return; } - _audio_dialog.reset(_panel, _film, _viewer); + _audio_dialog.emplace(_panel, _film, _viewer); _audio_dialog->Show(); } @@ -1062,9 +1062,9 @@ void DCPPanel::edit_audio_language_clicked () { DCPOMATIC_ASSERT (_film->audio_language()); - auto d = make_wx<LanguageTagDialog>(_panel, *_film->audio_language()); - if (d->ShowModal() == wxID_OK) { - _film->set_audio_language(d->get()); + LanguageTagDialog dialog(_panel, *_film->audio_language()); + if (dialog.ShowModal() == wxID_OK) { + _film->set_audio_language(dialog.get()); } } |
