summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorCarl Hetherington <cth@carlh.net>2021-04-10 15:27:41 +0200
committerCarl Hetherington <cth@carlh.net>2021-04-10 15:27:41 +0200
commit03dac68294060d84f57cf255584c2a7ca0dccc07 (patch)
treeebf705bd395f4f90bc10ee0d685d0488b447357d /src
parent2693be674d071a7d0d04d10f7b5e1de62734234d (diff)
Fix up hints about long subtitle lines.
Diffstat (limited to 'src')
-rw-r--r--src/lib/hints.cc12
1 files changed, 8 insertions, 4 deletions
diff --git a/src/lib/hints.cc b/src/lib/hints.cc
index ea524df50..e431cca7f 100644
--- a/src/lib/hints.cc
+++ b/src/lib/hints.cc
@@ -417,6 +417,12 @@ Hints::thread ()
_writer->write (player->get_subtitle_fonts());
+ if (_long_subtitle && !_very_long_subtitle) {
+ hint (_("At least one of your subtitle lines has more than 52 characters. It is recommended to make each line 52 characters at most in length."));
+ } else if (_very_long_subtitle) {
+ hint (_("At least one of your subtitle lines has more than 79 characters. You should make each line 79 characters at most in length."));
+ }
+
bool ccap_xml_too_big = false;
bool ccap_mxf_too_big = false;
bool subs_mxf_too_big = false;
@@ -554,14 +560,12 @@ Hints::open_subtitle (PlayerText text, DCPTimePeriod period)
longest_line = max (longest_line, i.text().length());
}
- if (longest_line > 52 && !_long_subtitle) {
+ if (longest_line > 52) {
_long_subtitle = true;
- hint (_("At least one of your subtitle lines has more than 52 characters. It is recommended to make each line 52 characters at most in length."));
}
- if (longest_line > 79 && !_very_long_subtitle) {
+ if (longest_line > 79) {
_very_long_subtitle = true;
- hint (_("At least one of your subtitle lines has more than 79 characters. You should make each line 79 characters at most in length."));
}
_last_subtitle = period;