Fix missing RMS plots in some cases (caused by plotting #inf

coordinates).

Reported-by: Markus Raab

2 files changed, 45 insertions, 36 deletions

diff --git a/src/wx/audio_plot.cc b/src/wx/audio_plot.cc
index 941566491..2e8b24e36 100644
--- a/src/wx/audio_plot.cc
+++ b/src/wx/audio_plot.cc
@@ -109,6 +109,15 @@ AudioPlot::set_message (wxString s)
 	Refresh ();
 }
 
+struct Metrics
+{
+	double db_label_width;
+	int height;
+	int y_origin;
+	float x_scale;
+	float y_scale;
+};
+
 void
 AudioPlot::paint ()
 {
@@ -130,34 +139,35 @@ AudioPlot::paint ()
 	wxDouble db_label_height;
 	wxDouble db_label_descent;
 	wxDouble db_label_leading;
-	gc->GetTextExtent (wxT ("-80dB"), &_db_label_width, &db_label_height, &db_label_descent, &db_label_leading);
+	Metrics metrics;
+	gc->GetTextExtent (wxT ("-80dB"), &metrics.db_label_width, &db_label_height, &db_label_descent, &db_label_leading);
 
-	_db_label_width += 8;
+	metrics.db_label_width += 8;
 	
-	int const data_width = GetSize().GetWidth() - _db_label_width;
+	int const data_width = GetSize().GetWidth() - metrics.db_label_width;
 	/* Assume all channels have the same number of points */
-	_x_scale = data_width / float (_analysis->points (0));
-	_height = GetSize().GetHeight ();
-	_y_origin = 32;
-	_y_scale = (_height - _y_origin) / -_minimum;
+	metrics.x_scale = data_width / float (_analysis->points (0));
+	metrics.height = GetSize().GetHeight ();
+	metrics.y_origin = 32;
+	metrics.y_scale = (metrics.height - metrics.y_origin) / -_minimum;
 
 	for (int i = _minimum; i <= 0; i += 10) {
-		int const y = (_height - (i - _minimum) * _y_scale) - _y_origin;
-		grid.MoveToPoint (_db_label_width - 4, y);
-		grid.AddLineToPoint (_db_label_width + data_width, y);
+		int const y = (metrics.height - (i - _minimum) * metrics.y_scale) - metrics.y_origin;
+		grid.MoveToPoint (metrics.db_label_width - 4, y);
+		grid.AddLineToPoint (metrics.db_label_width + data_width, y);
 		gc->DrawText (std_to_wx (String::compose ("%1dB", i)), 0, y - (db_label_height / 2));
 	}
 
 	gc->SetPen (*wxLIGHT_GREY_PEN);
 	gc->StrokePath (grid);
 
-	gc->DrawText (_("Time"), data_width, _height - _y_origin + db_label_height / 2);
+	gc->DrawText (_("Time"), data_width, metrics.height - metrics.y_origin + db_label_height / 2);
 	
 	if (_type_visible[AudioPoint::PEAK]) {
 		for (int c = 0; c < MAX_AUDIO_CHANNELS; ++c) {
 			wxGraphicsPath p = gc->CreatePath ();
 			if (_channel_visible[c] && c < _analysis->channels()) {
-				plot_peak (p, c);
+				plot_peak (p, c, metrics);
 			}
 			wxColour const col = _colours[c];
 			gc->SetPen (*wxThePenList->FindOrCreatePen (wxColour (col.Red(), col.Green(), col.Blue(), col.Alpha() / 2), 1, wxPENSTYLE_SOLID));
@@ -169,7 +179,7 @@ AudioPlot::paint ()
 		for (int c = 0; c < MAX_AUDIO_CHANNELS; ++c) {
 			wxGraphicsPath p = gc->CreatePath ();
 			if (_channel_visible[c] && c < _analysis->channels()) {
-				plot_rms (p, c);
+				plot_rms (p, c, metrics);
 			}
 			wxColour const col = _colours[c];
 			gc->SetPen (*wxThePenList->FindOrCreatePen (col, 1, wxPENSTYLE_SOLID));
@@ -178,9 +188,9 @@ AudioPlot::paint ()
 	}
 
 	wxGraphicsPath axes = gc->CreatePath ();
-	axes.MoveToPoint (_db_label_width, 0);
-	axes.AddLineToPoint (_db_label_width, _height - _y_origin);
-	axes.AddLineToPoint (_db_label_width + data_width, _height - _y_origin);
+	axes.MoveToPoint (metrics.db_label_width, 0);
+	axes.AddLineToPoint (metrics.db_label_width, metrics.height - metrics.y_origin);
+	axes.AddLineToPoint (metrics.db_label_width + data_width, metrics.height - metrics.y_origin);
 	gc->SetPen (*wxBLACK_PEN);
 	gc->StrokePath (axes);
 
@@ -188,19 +198,23 @@ AudioPlot::paint ()
 }
 
 float
-AudioPlot::y_for_linear (float p) const
+AudioPlot::y_for_linear (float p, Metrics const & metrics) const
 {
-	return _height - (20 * log10(p) - _minimum + _gain) * _y_scale - _y_origin;
+	if (p < 1e-4) {
+		p = 1e-4;
+	}
+	
+	return metrics.height - (20 * log10(p) - _minimum + _gain) * metrics.y_scale - metrics.y_origin;
 }
 
 void
-AudioPlot::plot_peak (wxGraphicsPath& path, int channel) const
+AudioPlot::plot_peak (wxGraphicsPath& path, int channel, Metrics const & metrics) const
 {
 	if (_analysis->points (channel) == 0) {
 		return;
 	}
 	
-	path.MoveToPoint (_db_label_width, y_for_linear (_analysis->get_point(channel, 0)[AudioPoint::PEAK]));
+	path.MoveToPoint (metrics.db_label_width, y_for_linear (_analysis->get_point(channel, 0)[AudioPoint::PEAK], metrics));
 
 	float peak = 0;
 	int const N = _analysis->points(channel);
@@ -212,19 +226,19 @@ AudioPlot::plot_peak (wxGraphicsPath& path, int channel) const
 		} else if (peak < 0) {
 			peak = 0;
 		}
-		
-		path.AddLineToPoint (_db_label_width + i * _x_scale, y_for_linear (peak));
+
+		path.AddLineToPoint (metrics.db_label_width + i * metrics.x_scale, y_for_linear (peak, metrics));
 	}
 }
 
 void
-AudioPlot::plot_rms (wxGraphicsPath& path, int channel) const
+AudioPlot::plot_rms (wxGraphicsPath& path, int channel, Metrics const & metrics) const
 {
 	if (_analysis->points (channel) == 0) {
 		return;
 	}
 	
-	path.MoveToPoint (_db_label_width, y_for_linear (_analysis->get_point(channel, 0)[AudioPoint::RMS]));
+	path.MoveToPoint (metrics.db_label_width, y_for_linear (_analysis->get_point(channel, 0)[AudioPoint::RMS], metrics));
 
 	list<float> smoothing;
 
@@ -247,7 +261,7 @@ AudioPlot::plot_rms (wxGraphicsPath& path, int channel) const
 			smoothing.push_back (last);
 		}
 	}
-	
+
 	for (int i = 0; i < N; ++i) {
 
 		int const next_for_window = i + after;
@@ -269,7 +283,7 @@ AudioPlot::plot_rms (wxGraphicsPath& path, int channel) const
 			p = sqrt (p / smoothing.size ());
 		}
 
-		path.AddLineToPoint (_db_label_width + i * _x_scale, y_for_linear (p));
+		path.AddLineToPoint (metrics.db_label_width + i * metrics.x_scale, y_for_linear (p, metrics));
 	}
 }
 
diff --git a/src/wx/audio_plot.h b/src/wx/audio_plot.h
index 094f8e1b0..7eedd8ffe 100644
--- a/src/wx/audio_plot.h
+++ b/src/wx/audio_plot.h
@@ -23,6 +23,8 @@
 #include "lib/util.h"
 #include "lib/audio_analysis.h"
 
+class Metrics;
+
 class AudioPlot : public wxPanel
 {
 public:
@@ -39,6 +41,9 @@ public:
 
 private:
 	void paint ();
+	void plot_peak (wxGraphicsPath &, int, Metrics const &) const;
+	void plot_rms (wxGraphicsPath &, int, Metrics const &) const;
+	float y_for_linear (float, Metrics const &) const;
 
 	boost::shared_ptr<AudioAnalysis> _analysis;
 	bool _channel_visible[MAX_AUDIO_CHANNELS];
@@ -48,16 +53,6 @@ private:
 	int _smoothing;
 	std::vector<wxColour> _colours;
 
-	void plot_peak (wxGraphicsPath &, int) const;
-	void plot_rms (wxGraphicsPath &, int) const;
-	float y_for_linear (float) const;
-
-	double _db_label_width;
-	int _height;
-	int _y_origin;
-	float _x_scale;
-	float _y_scale;
-
 	wxString _message;
 
 	static const int _minimum;