summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorCarl Hetherington <cth@carlh.net>2012-11-04 16:59:00 +0000
committerCarl Hetherington <cth@carlh.net>2012-11-04 16:59:00 +0000
commitac712b45bad948fc8f38cf4fa48a529f2024c7f5 (patch)
tree4e82a43b9f700e26faa9836a88f581a5a4c6bf75 /src
parent1d96023ab3987e55fd6452f655dfb900c6012881 (diff)
Remove minimal flag.
Diffstat (limited to 'src')
-rw-r--r--src/lib/decoder.cc10
-rw-r--r--src/lib/decoder.h7
-rw-r--r--src/lib/decoder_factory.cc10
-rw-r--r--src/lib/decoder_factory.h5
-rw-r--r--src/lib/examine_content_job.cc2
-rw-r--r--src/lib/ffmpeg_decoder.cc4
-rw-r--r--src/lib/ffmpeg_decoder.h2
-rw-r--r--src/lib/film.cc2
-rw-r--r--src/lib/imagemagick_decoder.cc4
-rw-r--r--src/lib/imagemagick_decoder.h2
-rw-r--r--src/lib/tiff_decoder.cc6
-rw-r--r--src/lib/tiff_decoder.h2
12 files changed, 18 insertions, 38 deletions
diff --git a/src/lib/decoder.cc b/src/lib/decoder.cc
index ee2beb3f3..34c04b260 100644
--- a/src/lib/decoder.cc
+++ b/src/lib/decoder.cc
@@ -46,14 +46,11 @@ using boost::shared_ptr;
/** @param f Film.
* @param o Options.
* @param j Job that we are running within, or 0
- * @param minimal true to do the bare minimum of work; just run through the content. Useful for acquiring
- * accurate frame counts as quickly as possible. This generates no video or audio output.
*/
-Decoder::Decoder (boost::shared_ptr<Film> f, boost::shared_ptr<const Options> o, Job* j, bool minimal)
+Decoder::Decoder (boost::shared_ptr<Film> f, boost::shared_ptr<const Options> o, Job* j)
: _film (f)
, _opt (o)
, _job (j)
- , _minimal (minimal)
, _video_frame_index (0)
, _delay_line (0)
, _delay_in_bytes (0)
@@ -250,11 +247,6 @@ Decoder::process_video (AVFrame* frame)
{
assert (_film->length());
- if (_minimal) {
- ++_video_frame_index;
- return;
- }
-
/* Use Film::length here as our one may be wrong */
if (_opt->decode_video_skip != 0 && (_video_frame_index % _opt->decode_video_skip) != 0) {
diff --git a/src/lib/decoder.h b/src/lib/decoder.h
index 5750858df..fe8149af9 100644
--- a/src/lib/decoder.h
+++ b/src/lib/decoder.h
@@ -52,7 +52,7 @@ class FilterGraph;
class Decoder
{
public:
- Decoder (boost::shared_ptr<Film>, boost::shared_ptr<const Options>, Job *, bool);
+ Decoder (boost::shared_ptr<Film>, boost::shared_ptr<const Options>, Job *);
virtual ~Decoder ();
/* Methods to query our input video */
@@ -121,11 +121,6 @@ protected:
/** associated Job, or 0 */
Job* _job;
- /** true to do the bare minimum of work; just run through the content. Useful for acquiring
- * accurate frame counts as quickly as possible. This generates no video or audio output.
- */
- bool _minimal;
-
private:
void emit_audio (uint8_t* data, int size);
diff --git a/src/lib/decoder_factory.cc b/src/lib/decoder_factory.cc
index 287bba0da..c3a6965e6 100644
--- a/src/lib/decoder_factory.cc
+++ b/src/lib/decoder_factory.cc
@@ -31,18 +31,16 @@ using std::string;
using boost::shared_ptr;
shared_ptr<Decoder>
-decoder_factory (
- shared_ptr<Film> f, shared_ptr<const Options> o, Job* j, bool minimal = false
- )
+decoder_factory (shared_ptr<Film> f, shared_ptr<const Options> o, Job* j)
{
if (boost::filesystem::is_directory (f->content_path ())) {
/* Assume a directory contains TIFFs */
- return shared_ptr<Decoder> (new TIFFDecoder (f, o, j, minimal));
+ return shared_ptr<Decoder> (new TIFFDecoder (f, o, j));
}
if (f->content_type() == STILL) {
- return shared_ptr<Decoder> (new ImageMagickDecoder (f, o, j, minimal));
+ return shared_ptr<Decoder> (new ImageMagickDecoder (f, o, j));
}
- return shared_ptr<Decoder> (new FFmpegDecoder (f, o, j, minimal));
+ return shared_ptr<Decoder> (new FFmpegDecoder (f, o, j));
}
diff --git a/src/lib/decoder_factory.h b/src/lib/decoder_factory.h
index b86c60c70..3c16d0ec0 100644
--- a/src/lib/decoder_factory.h
+++ b/src/lib/decoder_factory.h
@@ -25,8 +25,5 @@ class Decoder;
class Film;
class Options;
class Job;
-class Log;
-extern boost::shared_ptr<Decoder> decoder_factory (
- boost::shared_ptr<Film>, boost::shared_ptr<const Options>, Job *, bool minimal = false
- );
+extern boost::shared_ptr<Decoder> decoder_factory (boost::shared_ptr<Film>, boost::shared_ptr<const Options>, Job *);
diff --git a/src/lib/examine_content_job.cc b/src/lib/examine_content_job.cc
index ec0d2409b..e71ab361a 100644
--- a/src/lib/examine_content_job.cc
+++ b/src/lib/examine_content_job.cc
@@ -66,7 +66,7 @@ ExamineContentJob::run ()
descend (0.5);
- _decoder = decoder_factory (_film, o, this, true);
+ _decoder = decoder_factory (_film, o, this);
_decoder->go ();
_film->set_length (_decoder->video_frame_index());
diff --git a/src/lib/ffmpeg_decoder.cc b/src/lib/ffmpeg_decoder.cc
index f0e652cbe..77e8f365f 100644
--- a/src/lib/ffmpeg_decoder.cc
+++ b/src/lib/ffmpeg_decoder.cc
@@ -55,8 +55,8 @@ using std::vector;
using std::stringstream;
using boost::shared_ptr;
-FFmpegDecoder::FFmpegDecoder (shared_ptr<Film> f, shared_ptr<const Options> o, Job* j, bool minimal)
- : Decoder (f, o, j, minimal)
+FFmpegDecoder::FFmpegDecoder (shared_ptr<Film> f, shared_ptr<const Options> o, Job* j)
+ : Decoder (f, o, j)
, _format_context (0)
, _video_stream (-1)
, _audio_stream (-1)
diff --git a/src/lib/ffmpeg_decoder.h b/src/lib/ffmpeg_decoder.h
index fbd9e5255..0265f7478 100644
--- a/src/lib/ffmpeg_decoder.h
+++ b/src/lib/ffmpeg_decoder.h
@@ -52,7 +52,7 @@ class Log;
class FFmpegDecoder : public Decoder
{
public:
- FFmpegDecoder (boost::shared_ptr<Film>, boost::shared_ptr<const Options>, Job *, bool);
+ FFmpegDecoder (boost::shared_ptr<Film>, boost::shared_ptr<const Options>, Job *);
~FFmpegDecoder ();
/* Methods to query our input video */
diff --git a/src/lib/film.cc b/src/lib/film.cc
index cacd30764..cd5fc6535 100644
--- a/src/lib/film.cc
+++ b/src/lib/film.cc
@@ -877,7 +877,7 @@ Film::set_content (string c)
shared_ptr<Options> o (new Options ("", "", ""));
o->out_size = Size (1024, 1024);
- shared_ptr<Decoder> d = decoder_factory (shared_from_this(), o, 0, 0);
+ shared_ptr<Decoder> d = decoder_factory (shared_from_this(), o, 0);
set_size (d->native_size ());
set_frames_per_second (d->frames_per_second ());
diff --git a/src/lib/imagemagick_decoder.cc b/src/lib/imagemagick_decoder.cc
index 81349beca..cc2fd9d23 100644
--- a/src/lib/imagemagick_decoder.cc
+++ b/src/lib/imagemagick_decoder.cc
@@ -27,8 +27,8 @@ using namespace std;
using namespace boost;
ImageMagickDecoder::ImageMagickDecoder (
- boost::shared_ptr<Film> f, boost::shared_ptr<const Options> o, Job* j, bool minimal)
- : Decoder (f, o, j, minimal)
+ boost::shared_ptr<Film> f, boost::shared_ptr<const Options> o, Job* j)
+ : Decoder (f, o, j)
, _done (false)
{
_magick_image = new Magick::Image (_film->content_path ());
diff --git a/src/lib/imagemagick_decoder.h b/src/lib/imagemagick_decoder.h
index 85bcf4c5b..b7ab9af18 100644
--- a/src/lib/imagemagick_decoder.h
+++ b/src/lib/imagemagick_decoder.h
@@ -26,7 +26,7 @@ namespace Magick {
class ImageMagickDecoder : public Decoder
{
public:
- ImageMagickDecoder (boost::shared_ptr<Film>, boost::shared_ptr<const Options>, Job *, bool);
+ ImageMagickDecoder (boost::shared_ptr<Film>, boost::shared_ptr<const Options>, Job *);
float frames_per_second () const {
return static_frames_per_second ();
diff --git a/src/lib/tiff_decoder.cc b/src/lib/tiff_decoder.cc
index 2c050def6..7cca511dd 100644
--- a/src/lib/tiff_decoder.cc
+++ b/src/lib/tiff_decoder.cc
@@ -44,11 +44,9 @@ using namespace boost;
/** @param f Our Film.
* @param o Options.
* @param j Job that we are associated with, or 0.
- * @param minimal true to do the bare minimum of work; just run through the content. Useful for acquiring
- * accurate frame counts as quickly as possible. This generates no video or audio output.
*/
-TIFFDecoder::TIFFDecoder (boost::shared_ptr<Film> f, boost::shared_ptr<const Options> o, Job* j, bool minimal)
- : Decoder (f, o, j, minimal)
+TIFFDecoder::TIFFDecoder (boost::shared_ptr<Film> f, boost::shared_ptr<const Options> o, Job* j)
+ : Decoder (f, o, j)
{
string const dir = _film->content_path ();
diff --git a/src/lib/tiff_decoder.h b/src/lib/tiff_decoder.h
index c02a1d03d..1c33443cf 100644
--- a/src/lib/tiff_decoder.h
+++ b/src/lib/tiff_decoder.h
@@ -42,7 +42,7 @@ class Image;
class TIFFDecoder : public Decoder
{
public:
- TIFFDecoder (boost::shared_ptr<Film>, boost::shared_ptr<const Options>, Job *, bool);
+ TIFFDecoder (boost::shared_ptr<Film>, boost::shared_ptr<const Options>, Job *);
/* Methods to query our input video */
float frames_per_second () const;