diff options
| author | Carl Hetherington <cth@carlh.net> | 2023-07-02 22:03:28 +0200 |
|---|---|---|
| committer | Carl Hetherington <cth@carlh.net> | 2023-07-02 22:04:10 +0200 |
| commit | fc10e39ac88ee16a711d1d643f863e84dcd8157d (patch) | |
| tree | 070a6bd820888113e3c5f9f24089cb0e56e7c545 /src | |
| parent | 5f3ba49300f3e3d5ac36a2ce33dadc6d1ffc049c (diff) | |
Don't insert incorrect <Effect> nodes into metadata (#2581).
Previously we would add assume Effect=none (i.e. force all subtitles
to have no effect) if neither of the legacy tags Border or Shadow
were present in the metadata. In this case we should just leave
Effect as unset.
Diffstat (limited to 'src')
| -rw-r--r-- | src/lib/text_content.cc | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/lib/text_content.cc b/src/lib/text_content.cc index e4cbc601a..92a35b822 100644 --- a/src/lib/text_content.cc +++ b/src/lib/text_content.cc @@ -148,8 +148,6 @@ TextContent::TextContent (Content* parent, cxml::ConstNodePtr node, int version, _effect = dcp::Effect::BORDER; } else if (node->optional_bool_child("Shadow").get_value_or(false)) { _effect = dcp::Effect::SHADOW; - } else { - _effect = dcp::Effect::NONE; } auto effect = node->optional_string_child("Effect"); |