Fix incorrect handling of force-effect in subtitle appearance.

1 files changed, 14 insertions, 10 deletions

diff --git a/src/wx/subtitle_appearance_dialog.cc b/src/wx/subtitle_appearance_dialog.cc
index 8ae99bc73..8ae479746 100644
--- a/src/wx/subtitle_appearance_dialog.cc
+++ b/src/wx/subtitle_appearance_dialog.cc
@@ -210,16 +210,20 @@ SubtitleAppearanceDialog::apply ()
 	} else {
 		_content->subtitle->unset_colour ();
 	}
-	switch (_effect->GetSelection()) {
-	case NONE:
-		_content->subtitle->set_effect (dcp::NONE);
-		break;
-	case OUTLINE:
-		_content->subtitle->set_effect (dcp::BORDER);
-		break;
-	case SHADOW:
-		_content->subtitle->set_effect (dcp::SHADOW);
-		break;
+	if (_force_effect->GetValue()) {
+		switch (_effect->GetSelection()) {
+		case NONE:
+			_content->subtitle->set_effect (dcp::NONE);
+			break;
+		case OUTLINE:
+			_content->subtitle->set_effect (dcp::BORDER);
+			break;
+		case SHADOW:
+			_content->subtitle->set_effect (dcp::SHADOW);
+			break;
+		}
+	} else {
+		_content->subtitle->unset_effect ();
 	}
 	if (_force_effect_colour->GetValue ()) {
 		wxColour const ec = _effect_colour->GetColour ();